Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add audit for os.walk(), os.fwalk(), Path.glob() and Path.rglob() #83748

Closed
serhiy-storchaka opened this issue Feb 6, 2020 · 7 comments
Closed
Labels
3.9 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@serhiy-storchaka
Copy link
Member

BPO 39567
Nosy @ambv, @serhiy-storchaka, @zooba, @tirkarthi, @gousaiyang
PRs
  • bpo-39567: Add audit for os.walk(), os.fwalk(), Path.glob() and Path.rglob(). #18372
  • [3.8] bpo-39567: Add audit for os.walk(), os.fwalk(), Path.glob() and Path.rglob(). (GH-18372) #18478
  • bpo-39567: Document audit for os.walk, os.fwalk, Path.glob and Path.rglob. #18499
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2020-03-08.12:33:01.706>
    created_at = <Date 2020-02-06.08:20:48.606>
    labels = ['type-feature', 'library', '3.9']
    title = 'Add audit for os.walk(), os.fwalk(), Path.glob() and Path.rglob()'
    updated_at = <Date 2020-10-19.20:13:01.365>
    user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2020-10-19.20:13:01.365>
    actor = 'gousaiyang'
    assignee = 'none'
    closed = True
    closed_date = <Date 2020-03-08.12:33:01.706>
    closer = 'serhiy.storchaka'
    components = ['Library (Lib)']
    creation = <Date 2020-02-06.08:20:48.606>
    creator = 'serhiy.storchaka'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 39567
    keywords = ['patch']
    message_count = 7.0
    messages = ['361472', '361872', '361879', '361883', '361938', '363658', '379005']
    nosy_count = 5.0
    nosy_names = ['lukasz.langa', 'serhiy.storchaka', 'steve.dower', 'xtreak', 'gousaiyang']
    pr_nums = ['18372', '18478', '18499']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue39567'
    versions = ['Python 3.9']

    @serhiy-storchaka
    Copy link
    Member Author

    See bpo-38149.

    There is an audit for os.scandir(), but it would be useful to have information about higher-level operations.

    @serhiy-storchaka serhiy-storchaka added 3.9 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Feb 6, 2020
    @serhiy-storchaka serhiy-storchaka changed the title Add audit for os.walk, os.fwalk, Path.glob() and Path.rglob() Add audit for os.walk(), os.fwalk(), Path.glob() and Path.rglob() Feb 6, 2020
    @serhiy-storchaka serhiy-storchaka changed the title Add audit for os.walk, os.fwalk, Path.glob() and Path.rglob() Add audit for os.walk(), os.fwalk(), Path.glob() and Path.rglob() Feb 6, 2020
    @serhiy-storchaka
    Copy link
    Member Author

    New changeset f4f445b by Serhiy Storchaka in branch 'master':
    bpo-39567: Add audit for os.walk(), os.fwalk(), Path.glob() and Path.rglob(). (GH-18372)
    f4f445b

    @tirkarthi
    Copy link
    Member

    Do these new audit events have to be documented?

    @zooba
    Copy link
    Member

    zooba commented Feb 12, 2020

    Yes, they should be.

    They can also be backported to 3.8 - it was deliberate in the original PEP that adding new events is not a breaking change or a new feature.

    @serhiy-storchaka
    Copy link
    Member Author

    Oh, I did not know about the audit-event directive. Thanks Karthikeyan.

    As for backporting this to 3.8 I left it on to the RM.

    @serhiy-storchaka
    Copy link
    Member Author

    New changeset db283b3 by Serhiy Storchaka in branch 'master':
    bpo-39567: Document audit for os.walk, os.fwalk, Path.glob and Path.rglob. (GH-18499)
    db283b3

    @gousaiyang
    Copy link
    Mannequin

    gousaiyang mannequin commented Oct 19, 2020

    Should we backport this to 3.8? I believe that we should either backport this to 3.8 or document that these audit events are new in 3.9.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.9 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants