Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_distutils fails for Windows debug build #83736

Closed
zooba opened this issue Feb 5, 2020 · 4 comments
Closed

test_distutils fails for Windows debug build #83736

zooba opened this issue Feb 5, 2020 · 4 comments
Assignees
@zooba
Labels
OS-windows stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@zooba
Copy link
Member

zooba commented Feb 5, 2020

BPO 39555
Nosy @pfmoore, @scoder, @vstinner, @tjguk, @merwok, @encukou, @zware, @zooba, @dstufft, @pablogsal
PRs
  • bpo-39555: Fix distutils test to handle _d suffix on Windows debug build #18357
  • [3.8] bpo-39555: Fix distutils test to handle _d suffix on Windows debug build (GH-18357) #18548
  • [3.8] bpo-39432: Implement PEP-489 algorithm for non-ascii "PyInit_*" symbol names in distutils (GH-18150) #18546
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
closed_at = <Date 2020-02-06.04:48:34.335>
created_at = <Date 2020-02-05.04:59:17.639>
labels = ['type-bug', 'library', 'OS-windows']
title = 'test_distutils fails for Windows debug build'
updated_at = <Date 2020-02-18.21:39:31.591>
user = 'https://github.com/zooba'

    bugs.python.org fields:

    activity = <Date 2020-02-18.21:39:31.591>
actor = 'petr.viktorin'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2020-02-06.04:48:34.335>
closer = 'steve.dower'
components = ['Distutils', 'Windows']
creation = <Date 2020-02-05.04:59:17.639>
creator = 'steve.dower'
dependencies = []
files = []
hgrepos = []
issue_num = 39555
keywords = ['patch']
message_count = 4.0
messages = ['361406', '361470', '362214', '362236']
nosy_count = 10.0
nosy_names = ['paul.moore', 'scoder', 'vstinner', 'tim.golden', 'eric.araujo', 'petr.viktorin', 'zach.ware', 'steve.dower', 'dstufft', 'pablogsal']
pr_nums = ['18357', '18548', '18546']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue39555'
versions = []
    @zooba
    Copy link
    Member Author

    zooba commented Feb 5, 2020

    From https://buildbot.python.org/all/#/builders/129/builds/306

    ======================================================================
    FAIL: test_unicode_module_names (distutils.tests.test_build_ext.BuildExtTestCase)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\tests\test_build_ext.py", line 315, in test_unicode_module_names
    self.assertRegex(cmd.get_ext_filename(modules[0].name), r'foo\..*')
AssertionError: Regex didn't match: 'foo\\..*' not found in 'foo_d.cp39-win_amd64.pyd'

    ======================================================================
    FAIL: test_unicode_module_names (distutils.tests.test_build_ext.ParallelBuildExtTestCase)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\lib\distutils\tests\test_build_ext.py", line 315, in test_unicode_module_names
    self.assertRegex(cmd.get_ext_filename(modules[0].name), r'foo\..*')
AssertionError: Regex didn't match: 'foo\\..*' not found in 'foo_d.cp39-win_amd64.pyd'

    @zooba zooba added stdlib Python modules in the Lib dir OS-windows type-bug An unexpected behavior, bug, or error labels Feb 5, 2020
    @zooba
    Copy link
    Member Author

    zooba commented Feb 6, 2020

    New changeset ab0d892 by Steve Dower in branch 'master':
    bpo-39555: Fix distutils test to handle _d suffix on Windows debug build (GH-18357)
    ab0d892

    @zooba zooba closed this as completed Feb 6, 2020
    @zooba zooba self-assigned this Feb 6, 2020
    @zooba zooba closed this as completed Feb 6, 2020
    @zooba zooba self-assigned this Feb 6, 2020
    @vstinner
    Copy link
    Member

    This issue is related to bpo-39432.

    commit 9538bc9
    Author: Stefan Behnel <stefan_ml@behnel.de>
    Date: Tue Feb 4 16:24:30 2020 +0100

    bpo-39432: Implement PEP-489 algorithm for non-ascii "PyInit_*" symbol names in distutils (GH-18150)



Make it export the correct init symbol also on Windows.



https://bugs.python.org/issue39432

    @encukou
    Copy link
    Member

    encukou commented Feb 18, 2020

    New changeset d77e771 by Miss Islington (bot) in branch '3.8':
    bpo-39555: Fix distutils test to handle _d suffix on Windows debug build (GH-18357) (GH-18548)
    d77e771

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @zooba zooba

    Labels
    OS-windows stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @vstinner @encukou @zooba