Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code from longobject.c complexobject.c floatobject.c #83596

Closed
corona10 opened this issue Jan 21, 2020 · 5 comments
Closed

Remove unused code from longobject.c complexobject.c floatobject.c #83596

corona10 opened this issue Jan 21, 2020 · 5 comments
Assignees

Comments

@corona10
Copy link
Member

BPO 39415
Nosy @mdickinson, @benjaminp, @vadmium, @serhiy-storchaka, @corona10, @miss-islington
PRs
  • bpo-39415: Remove unused codes from long/complex/floatobject.c #18105
  • [3.8] closes bpo-39415: Remove unused codes from longobject.c complexobject.c floatobject.c. (GH-18105) #18112
  • [3.8] closes bpo-39415: Remove unused codes from longobject.c complexobject.c floatobject.c. (GH-18105) #18113
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/corona10'
    closed_at = <Date 2020-01-22.02:49:38.848>
    created_at = <Date 2020-01-21.17:09:17.106>
    labels = []
    title = 'Remove unused code from longobject.c complexobject.c floatobject.c'
    updated_at = <Date 2020-01-22.04:18:14.118>
    user = 'https://github.com/corona10'

    bugs.python.org fields:

    activity = <Date 2020-01-22.04:18:14.118>
    actor = 'corona10'
    assignee = 'corona10'
    closed = True
    closed_date = <Date 2020-01-22.02:49:38.848>
    closer = 'benjamin.peterson'
    components = []
    creation = <Date 2020-01-21.17:09:17.106>
    creator = 'corona10'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 39415
    keywords = ['patch']
    message_count = 5.0
    messages = ['360408', '360425', '360444', '360446', '360448']
    nosy_count = 6.0
    nosy_names = ['mark.dickinson', 'benjamin.peterson', 'martin.panter', 'serhiy.storchaka', 'corona10', 'miss-islington']
    pr_nums = ['18105', '18112', '18113']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue39415'
    versions = []

    @corona10
    Copy link
    Member Author

    For example, long_is_finite has not been used for 12 years.

    @serhiy-storchaka
    Copy link
    Member

    A patch was proposed in bpo-18842.

    @benjaminp
    Copy link
    Contributor

    New changeset 0d5eac8 by Benjamin Peterson (Dong-hee Na) in branch 'master':
    closes bpo-39415: Remove unused codes from longobject.c complexobject.c floatobject.c. (GH-18105)
    0d5eac8

    @miss-islington
    Copy link
    Contributor

    New changeset a755410 by Miss Islington (bot) in branch '3.8':
    closes bpo-39415: Remove unused codes from longobject.c complexobject.c floatobject.c. (GH-18105)
    a755410

    @corona10
    Copy link
    Member Author

    Thank you to all who participated in this discussion and review :)

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    No branches or pull requests

    4 participants