Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch to implement a real ftplib test suite #48189

Closed
giampaolo opened this issue Sep 22, 2008 · 9 comments
Closed

Patch to implement a real ftplib test suite #48189

giampaolo opened this issue Sep 22, 2008 · 9 comments
Assignees
@benjaminp

Comments

@giampaolo
Copy link
Contributor

BPO 3939
Nosy @gvanrossum, @facundobatista, @giampaolo, @benjaminp
Files
  • test_ftplib.patch: ftplib test suite
  • test_ftplib.patch: 2nd version modified after Benjamin's remarks
  • test_ftplib.patch: patch about issue raised in msg 73950
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/benjaminp'
closed_at = <Date 2008-09-27.02:50:25.184>
created_at = <Date 2008-09-22.23:42:22.776>
labels = []
title = 'Patch to implement a real ftplib test suite'
updated_at = <Date 2008-09-28.20:59:05.122>
user = 'https://github.com/giampaolo'

    bugs.python.org fields:

    activity = <Date 2008-09-28.20:59:05.122>
actor = 'benjamin.peterson'
assignee = 'benjamin.peterson'
closed = True
closed_date = <Date 2008-09-27.02:50:25.184>
closer = 'benjamin.peterson'
components = []
creation = <Date 2008-09-22.23:42:22.776>
creator = 'giampaolo.rodola'
dependencies = []
files = ['11564', '11582', '11640']
hgrepos = []
issue_num = 3939
keywords = ['patch']
message_count = 9.0
messages = ['73605', '73611', '73635', '73682', '73913', '73917', '73950', '73966', '73987']
nosy_count = 4.0
nosy_names = ['gvanrossum', 'facundobatista', 'giampaolo.rodola', 'benjamin.peterson']
pr_nums = []
priority = 'high'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue3939'
versions = ['Python 2.6']
    @giampaolo
    Copy link
    Contributor Author

    ftplib module is currently lacking a test suite which actually connects
    to a FTP server and uses the FTP class methods and facilities.
    Bug bpo-3911, discovered just a bunch of weeks before the stable release of
    Python 3.0, is an example of how much a test suite is necessary.
    As demanded by Benjamin Peterson in bpo-3911, I started working on test
    suite which implements an asyncore-based dummy FTP server which sends
    fixed response codes that I used to test all the relevant FTP class methods.
    Tests for the IPv6 module facilities are also included.
    Although not that useful (IMHO) I didn't remove the old tests about
    timeouts.

    Tested against Python 2.6-RC2 on Windows XP SP3, Linux 2.6.20 and
    FreeBSD 7.0.

    @benjaminp
    Copy link
    Contributor

    Awesome! I'll look at this soon.

    @benjaminp benjaminp self-assigned this Sep 23, 2008
    @benjaminp
    Copy link
    Contributor

    Giampaolo, my review comments are on Rietveld:
    http://codereview.appspot.com/5698

    @giampaolo
    Copy link
    Contributor Author

    Patch modified after the remarks discussed with Benjamin is in attachment.

    @benjaminp
    Copy link
    Contributor

    Excellent! Barry gave me permission to put this in 2.6, so I'll do so soon.

    @benjaminp
    Copy link
    Contributor

    Commited in r66634.

    @benjaminp
    Copy link
    Contributor

    Giampaolo, I'm seeing some failures on the buildbots like this:
    http://python.org/dev/buildbot/stable/ia64%20Ubuntu%203.0/builds/612/step-test/0

    Do you know where they are arising from?

    @giampaolo
    Copy link
    Contributor Author

    I think the patch in attachment could solve the problem.
    Note: done against the 2.x trunk; changes for 3.x are the same.

    @benjaminp
    Copy link
    Contributor

    Thanks. That seems to have done the trick.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @benjaminp benjaminp

    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @benjaminp @giampaolo