Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDLE: Changes to keybindings aren't reverted on cancel #83569

Closed
csabella opened this issue Jan 19, 2020 · 5 comments
Closed

IDLE: Changes to keybindings aren't reverted on cancel #83569

csabella opened this issue Jan 19, 2020 · 5 comments
Assignees
@terryjreedy
Labels
3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes topic-IDLE type-feature A feature request or enhancement

Comments

@csabella
Copy link
Contributor

BPO 39388
Nosy @terryjreedy, @csabella, @miss-islington
PRs
  • bpo-39388: IDLE: Fix bug when cancelling out of configdialog #18068
  • [3.8] bpo-39388: IDLE: Fix bug when cancelling out of configdialog (GH-18068) #18178
  • [3.7] bpo-39388: IDLE: Fix bug when cancelling out of configdialog (GH-18068) #18179
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2020-01-25.11:37:53.822>
created_at = <Date 2020-01-19.17:26:54.776>
labels = ['3.8', 'expert-IDLE', 'type-feature', '3.7', '3.9']
title = "IDLE: Changes to keybindings aren't reverted on cancel"
updated_at = <Date 2020-01-25.11:37:53.821>
user = 'https://github.com/csabella'

    bugs.python.org fields:

    activity = <Date 2020-01-25.11:37:53.821>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2020-01-25.11:37:53.822>
closer = 'terry.reedy'
components = ['IDLE']
creation = <Date 2020-01-19.17:26:54.776>
creator = 'cheryl.sabella'
dependencies = []
files = []
hgrepos = []
issue_num = 39388
keywords = ['patch']
message_count = 5.0
messages = ['360262', '360667', '360675', '360676', '360677']
nosy_count = 3.0
nosy_names = ['terry.reedy', 'cheryl.sabella', 'miss-islington']
pr_nums = ['18068', '18178', '18179']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue39388'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']
    @csabella
    Copy link
    Contributor Author

    In https://bugs.python.org/issue35598#msg332634, Terry mentioned a bug when updating the configuration of a key, but then cancelling out of configdialog.

    Change a key binding. Cancel. Re-open config dialog. Try to change back. It says original binding is in use -- which it is if one closes IDLE and reopens, or opens a different instance. It seems that cancel is not properly undoing the temporary change.

    @csabella csabella added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes labels Jan 19, 2020
    @csabella csabella added topic-IDLE type-feature A feature request or enhancement labels Jan 19, 2020
    @terryjreedy
    Copy link
    Member

    Thank you for the reminder. There must be other changes not being cancelled, but I will finish this fix instead of measuring the bug ;-).

    @terryjreedy
    Copy link
    Member

    New changeset d0d9fa8 by Terry Jan Reedy (Cheryl Sabella) in branch 'master':
    bpo-39388: IDLE: Fix bug when cancelling out of configdialog (GH-18068)
    d0d9fa8

    @miss-islington
    Copy link
    Contributor

    New changeset a234492 by Miss Islington (bot) in branch '3.8':
    bpo-39388: IDLE: Fix bug when cancelling out of configdialog (GH-18068)
    a234492

    @miss-islington
    Copy link
    Contributor

    New changeset fd9ce2b by Miss Islington (bot) in branch '3.7':
    bpo-39388: IDLE: Fix bug when cancelling out of configdialog (GH-18068)
    fd9ce2b

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @terryjreedy terryjreedy

    Labels
    3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes topic-IDLE type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @terryjreedy @csabella @miss-islington