Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The header files in Include/ have many declarations with no definition #83553

Closed
pablogsal opened this issue Jan 17, 2020 · 8 comments
Closed

The header files in Include/ have many declarations with no definition #83553

pablogsal opened this issue Jan 17, 2020 · 8 comments
Labels
3.9 only security fixes build The build process and cross-build type-feature A feature request or enhancement

Comments

@pablogsal
Copy link
Member

BPO 39372
Nosy @vstinner, @encukou, @serhiy-storchaka, @ZackerySpytz, @pablogsal
PRs
  • bpo-39372: Clean header files of declared interfaces with no implementations #18037
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2020-01-17.17:47:13.671>
labels = ['type-feature', '3.9', 'build']
title = 'The header files in Include/ have many declarations with no definition'
updated_at = <Date 2020-06-09.16:44:46.269>
user = 'https://github.com/pablogsal'

    bugs.python.org fields:

    activity = <Date 2020-06-09.16:44:46.269>
actor = 'vstinner'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Build']
creation = <Date 2020-01-17.17:47:13.671>
creator = 'pablogsal'
dependencies = []
files = []
hgrepos = []
issue_num = 39372
keywords = ['patch']
message_count = 8.0
messages = ['360204', '360207', '360229', '360238', '360240', '360246', '371083', '371125']
nosy_count = 5.0
nosy_names = ['vstinner', 'petr.viktorin', 'serhiy.storchaka', 'ZackerySpytz', 'pablogsal']
pr_nums = ['18037']
priority = 'normal'
resolution = None
stage = 'resolved'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue39372'
versions = ['Python 3.9']
    @pablogsal
    Copy link
    Member Author

    There are many declarations that lack definitions in our header files that should be cleaned (linking against those symbols will fail so removing them should be safe if I am not missing something).

    @pablogsal pablogsal added 3.9 only security fixes build The build process and cross-build type-feature A feature request or enhancement labels Jan 17, 2020
    @serhiy-storchaka
    Copy link
    Member

    Good catch!

    All removals LGTM.

    @pablogsal
    Copy link
    Member Author

    New changeset cd7db76 by Pablo Galindo in branch 'master':
    bpo-39372: Clean header files of declared interfaces with no implementations (GH-18037)
    cd7db76

    @ZackerySpytz
    Copy link
    Mannequin

    ZackerySpytz mannequin commented Jan 18, 2020

    The removal of PyNoArgsFunction is the subject of bpo-18091.

    @serhiy-storchaka
    Copy link
    Member

    Maybe backport this change (except PyNoArgsFunction)?

    @pablogsal
    Copy link
    Member Author

    Maybe backport this change (except PyNoArgsFunction)?

    I didn't think of backporting to reduce the possibilities of something going wrong, but is true that a backport without PyNoArgsFunction should be harmless.

    Reopening the issue meanwhile I do on the backports.

    @pablogsal pablogsal reopened this Jan 18, 2020
    @encukou
    Copy link
    Member

    encukou commented Jun 9, 2020

    Since the removal of PyNoArgsFunction breaks user code, does it deserve a mention in What's New – Porting to Python 3.9?

    @vstinner
    Copy link
    Member

    vstinner commented Jun 9, 2020

    Maybe backport this change (except PyNoArgsFunction)?

    I don't think that it's a good idea. I suggest to only do cleanup in the master branch, just in case if something goes wrong. Like the PyNoArgsFunction removal :-)

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.9 only security fixes build The build process and cross-build type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    5 participants
    @vstinner @encukou @serhiy-storchaka @pablogsal @furkanonder