Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bz2: Remove deprecated buffering parameter of bz2.BZ2File #83538

Closed
vstinner opened this issue Jan 16, 2020 · 6 comments
Closed

bz2: Remove deprecated buffering parameter of bz2.BZ2File #83538

vstinner opened this issue Jan 16, 2020 · 6 comments
Labels
3.9 only security fixes stdlib Python modules in the Lib dir

Comments

@vstinner
Copy link
Member

BPO 39357
Nosy @vstinner, @tirkarthi
PRs
  • bpo-39357: Remove buffering parameter of bz2.BZ2File #18028
  • bpo-39357: Update bz2 docstring: remove buffering #18036
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-01-16.14:33:45.500>
created_at = <Date 2020-01-16.10:22:45.861>
labels = ['library', '3.9']
title = 'bz2: Remove deprecated buffering parameter of bz2.BZ2File'
updated_at = <Date 2020-01-17.12:58:51.958>
user = 'https://github.com/vstinner'

    bugs.python.org fields:

    activity = <Date 2020-01-17.12:58:51.958>
actor = 'xtreak'
assignee = 'none'
closed = True
closed_date = <Date 2020-01-16.14:33:45.500>
closer = 'vstinner'
components = ['Library (Lib)']
creation = <Date 2020-01-16.10:22:45.861>
creator = 'vstinner'
dependencies = []
files = []
hgrepos = []
issue_num = 39357
keywords = ['patch']
message_count = 6.0
messages = ['360114', '360125', '360168', '360180', '360181', '360183']
nosy_count = 2.0
nosy_names = ['vstinner', 'xtreak']
pr_nums = ['18028', '18036']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue39357'
versions = ['Python 3.9']
    @vstinner
    Copy link
    Member Author

    The "buffering" parameter of bz2.BZ2File is deprecated for 12 years.

    Using it was emitting a DeprecationWarning since Python 3.0.

    Attached PR removes it.

    @vstinner vstinner added 3.9 only security fixes stdlib Python modules in the Lib dir labels Jan 16, 2020
    @vstinner
    Copy link
    Member Author

    New changeset 9baf242 by Victor Stinner in branch 'master':
    bpo-39357: Remove buffering parameter of bz2.BZ2File (GH-18028)
    9baf242

    @tirkarthi
    Copy link
    Member

    cpython/Lib/bz2.py

    Line 50 in 9baf242

    buffering is ignored since Python 3.0. Its use is deprecated.
    contains similar reference about buffering parameter deprecation like bz2.rst which could also be removed. Thanks.

    @vstinner
    Copy link
    Member Author

    New changeset 10fd6b2 by Victor Stinner in branch 'master':
    bpo-39357: Update bz2 docstring: remove buffering (GH-18036)
    10fd6b2

    @vstinner
    Copy link
    Member Author

    Thanks Karthikeyan, I forgot about the docstring.

    @tirkarthi
    Copy link
    Member

    Thanks for the fix Victor :)

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.9 only security fixes stdlib Python modules in the Lib dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @vstinner @tirkarthi