Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge nntplib._NNTPBase and nntplib.NNTP #83486

Closed
corona10 opened this issue Jan 11, 2020 · 8 comments
Closed

Merge nntplib._NNTPBase and nntplib.NNTP #83486

corona10 opened this issue Jan 11, 2020 · 8 comments
Labels
3.9 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@corona10
Copy link
Member

BPO 39305
Nosy @vstinner, @corona10, @LucianaMarques
PRs
  • bpo-39305: Refactor nntplib.py #18045
  • bpo-39305: Update nntplib to merge nntplib.NNTP and nntplib._NNTPBase #19817
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-05-16.10:33:18.073>
created_at = <Date 2020-01-11.15:52:28.737>
labels = ['type-feature', 'library', '3.9']
title = 'Merge nntplib._NNTPBase and nntplib.NNTP'
updated_at = <Date 2020-05-16.15:23:15.238>
user = 'https://github.com/corona10'

    bugs.python.org fields:

    activity = <Date 2020-05-16.15:23:15.238>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2020-05-16.10:33:18.073>
closer = 'corona10'
components = ['Library (Lib)']
creation = <Date 2020-01-11.15:52:28.737>
creator = 'corona10'
dependencies = []
files = []
hgrepos = []
issue_num = 39305
keywords = ['patch']
message_count = 8.0
messages = ['359803', '359989', '360012', '360066', '360218', '369038', '369039', '369052']
nosy_count = 3.0
nosy_names = ['vstinner', 'corona10', 'lucianamarques']
pr_nums = ['18045', '19817']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue39305'
versions = ['Python 3.9']
    @corona10
    Copy link
    Member Author

    See: #17939 (review)

    There was partial refactoring through PR 17939.
    I and Victor think that nntplib._NNTPBase can be removed by merging nntplib._NNTPBase and nntplib.NNTP.

    The only care point would be rewriting unit testing code which depends on nntplib._NNTPBase.

    @corona10 corona10 added 3.9 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Jan 11, 2020
    @lucianamarques
    Copy link
    Mannequin

    lucianamarques mannequin commented Jan 14, 2020

    Hey, I'm taking a look into this!

    @corona10
    Copy link
    Member Author

    @LucianaMarques

    Good news, if you submit the patch.
    Please ping me and @vstinner :)

    @lucianamarques
    Copy link
    Mannequin

    lucianamarques mannequin commented Jan 15, 2020

    Thank you, I am creating the patch now and will submit it later today!

    @lucianamarques
    Copy link
    Mannequin

    lucianamarques mannequin commented Jan 17, 2020

    I just uploaded the PR, please take a look when you have a chance :)

    I did my best trying to come up with a good code.

    @corona10
    Copy link
    Member Author

    New changeset aa92a7c by Dong-hee Na in branch 'master':
    bpo-39305: Update nntplib to merge nntplib.NNTP and nntplib._NNTPBase (GH-19817)
    aa92a7c

    @corona10
    Copy link
    Member Author

    I am no closing this issue :)

    Thank you for the suggestion, Victor.
    And also thank you for the interest in this issue, Luciana :)

    @vstinner
    Copy link
    Member

    Thanks, that's a nice simplification of the code ;-)

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.9 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @vstinner @corona10