Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update news.gmane.org to news.gmane.io #83423

Closed
corona10 opened this issue Jan 7, 2020 · 7 comments
Closed

Update news.gmane.org to news.gmane.io #83423

corona10 opened this issue Jan 7, 2020 · 7 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes stdlib Python modules in the Lib dir tests Tests in the Lib/test dir

Comments

@corona10
Copy link
Member

corona10 commented Jan 7, 2020

BPO 39242
Nosy @pitrou, @vstinner, @corona10, @miss-islington
PRs
  • bpo-39242: Updated the Gmane domain into news.gmane.io #17903
  • [3.8] bpo-39242: Updated the Gmane domain into news.gmane.io (GH-17903) #17904
  • [3.7] bpo-39242: Updated the Gmane domain into news.gmane.io (GH-17903) #17905
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-01-08.15:31:39.890>
created_at = <Date 2020-01-07.07:28:05.063>
labels = ['tests', '3.8', '3.7', 'library', '3.9']
title = 'Update news.gmane.org to news.gmane.io'
updated_at = <Date 2020-01-08.15:48:37.198>
user = 'https://github.com/corona10'

    bugs.python.org fields:

    activity = <Date 2020-01-08.15:48:37.198>
actor = 'miss-islington'
assignee = 'none'
closed = True
closed_date = <Date 2020-01-08.15:31:39.890>
closer = 'vstinner'
components = ['Library (Lib)', 'Tests']
creation = <Date 2020-01-07.07:28:05.063>
creator = 'corona10'
dependencies = []
files = []
hgrepos = []
issue_num = 39242
keywords = ['patch']
message_count = 7.0
messages = ['359491', '359586', '359592', '359597', '359598', '359600', '359601']
nosy_count = 4.0
nosy_names = ['pitrou', 'vstinner', 'corona10', 'miss-islington']
pr_nums = ['17903', '17904', '17905']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue39242'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']
    @corona10
    Copy link
    Member Author

    corona10 commented Jan 7, 2020

    https://discuss.python.org/t/ot-gmane-server-moving/2967

    AFAIK, we have several codes that use news.gmane.org.
    According to article, don't we have to update it?
    (sorry I am not a committer, so I don't have permission to write on that)

    https://github.com/python/cpython/search?q=news.gmane.org&unscoped_q=news.gmane.org

    @vstinner
    Copy link
    Member

    vstinner commented Jan 8, 2020

    Correct: nntplib and test_nntplib should be updated:

    Doc/library/nntplib.rst:23:   >>> s = nntplib.NNTP('news.gmane.org')
Doc/library/nntplib.rst:47:   >>> s = nntplib.NNTP('news.gmane.org')
Doc/library/nntplib.rst:76:    >>> with NNTP('news.gmane.org') as n:
Doc/library/nntplib.rst:228:      >>> s = NNTP('news.gmane.org')
Doc/whatsnew/3.3.rst:1565:  >>> with NNTP('news.gmane.org') as n:
Lib/nntplib.py:1110:    parser.add_argument('-s', '--server', default='news.gmane.org',
Lib/test/test_nntplib.py:642:                    "\tXref: news.gmane.org gmane.comp.python.authors:57"
Lib/test/test_nntplib.py:1128:            "xref": "news.gmane.org gmane.comp.python.authors:57"

    Do you want to work on a pull request?

    @corona10
    Copy link
    Member Author

    corona10 commented Jan 8, 2020

    @vstinner

    Oh! sure, I will submit the PR right a way :)

    @vstinner
    Copy link
    Member

    vstinner commented Jan 8, 2020

    New changeset 2e6a8ef by Victor Stinner (Dong-hee Na) in branch 'master':
    bpo-39242: Updated the Gmane domain into news.gmane.io (GH-17903)
    2e6a8ef

    @vstinner
    Copy link
    Member

    vstinner commented Jan 8, 2020

    Thanks Dong-hee Na for the update. The fix landed in master, backports to 3.7 and 3.8 will automatically follow once the CI test will pas.

    @vstinner vstinner added stdlib Python modules in the Lib dir tests Tests in the Lib/test dir 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes labels Jan 8, 2020
    @vstinner vstinner closed this as completed Jan 8, 2020
    @vstinner vstinner added stdlib Python modules in the Lib dir tests Tests in the Lib/test dir 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes labels Jan 8, 2020
    @vstinner vstinner closed this as completed Jan 8, 2020
    @miss-islington
    Copy link
    Contributor

    New changeset 00ac28a by Miss Islington (bot) in branch '3.7':
    bpo-39242: Updated the Gmane domain into news.gmane.io (GH-17903)
    00ac28a

    @miss-islington
    Copy link
    Contributor

    New changeset b24e4fa by Miss Islington (bot) in branch '3.8':
    bpo-39242: Updated the Gmane domain into news.gmane.io (GH-17903)
    b24e4fa

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes stdlib Python modules in the Lib dir tests Tests in the Lib/test dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @vstinner @corona10 @miss-islington