Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock may not be released in Logger.isEnabledFor #83379

Closed
DerekTBrown mannequin opened this issue Jan 2, 2020 · 5 comments
Closed

Lock may not be released in Logger.isEnabledFor #83379

DerekTBrown mannequin opened this issue Jan 2, 2020 · 5 comments
Labels
3.7 (EOL) end of life stdlib Python modules in the Lib dir type-crash A hard crash of the interpreter, possibly with a core dump

Comments

@DerekTBrown
Copy link
Mannequin

DerekTBrown mannequin commented Jan 2, 2020

BPO 39198
Nosy @vsajip, @DerekTBrown
PRs
  • bpo-39198: Ensure logging global lock is released on exception in isEnabledFor #17689
  • [3.8] bpo-39198: Ensure logging global lock is released on exception in isEnabledFor (GH-17689) #17897
  • [3.7] bpo-39198: Ensure logging global lock is released on exception in isEnabledFor (GH-17689) #17898
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-01-07.17:04:16.245>
created_at = <Date 2020-01-02.20:10:20.838>
labels = ['3.7', 'library', 'type-crash']
title = 'Lock may not be released in Logger.isEnabledFor'
updated_at = <Date 2020-01-07.17:04:16.245>
user = 'https://github.com/DerekTBrown'

    bugs.python.org fields:

    activity = <Date 2020-01-07.17:04:16.245>
actor = 'vinay.sajip'
assignee = 'none'
closed = True
closed_date = <Date 2020-01-07.17:04:16.245>
closer = 'vinay.sajip'
components = ['Library (Lib)']
creation = <Date 2020-01-02.20:10:20.838>
creator = 'derektbrown'
dependencies = []
files = []
hgrepos = []
issue_num = 39198
keywords = ['patch']
message_count = 5.0
messages = ['359219', '359220', '359520', '359521', '359522']
nosy_count = 2.0
nosy_names = ['vinay.sajip', 'derektbrown']
pr_nums = ['17689', '17897', '17898']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'crash'
url = 'https://bugs.python.org/issue39198'
versions = ['Python 3.6', 'Python 3.7']
    @DerekTBrown
    Copy link
    Mannequin Author

    DerekTBrown mannequin commented Jan 2, 2020

    If an exception were to be thrown in a particular block of code (say, by asyncio timeouts or stopit) within the isEnabledFor function of logging, the logging global lock may not be released appropriately, resulting in deadlock.

    @DerekTBrown DerekTBrown mannequin added 3.7 (EOL) end of life stdlib Python modules in the Lib dir type-crash A hard crash of the interpreter, possibly with a core dump labels Jan 2, 2020
    @DerekTBrown
    Copy link
    Mannequin Author

    DerekTBrown mannequin commented Jan 2, 2020

    PR is here: #17689

    @vsajip
    Copy link
    Member

    vsajip commented Jan 7, 2020

    New changeset 950c679 by Vinay Sajip (Derek Brown) in branch 'master':
    bpo-39198: Ensure logging global lock is released on exception in isEnabledFor (GH-17689)
    950c679

    @vsajip
    Copy link
    Member

    vsajip commented Jan 7, 2020

    New changeset bff48c6 by Vinay Sajip (Miss Islington (bot)) in branch '3.8':
    bpo-39198: Ensure logging global lock is released on exception in isEnabledFor (GH-17689) (GH-17897)
    bff48c6

    @vsajip
    Copy link
    Member

    vsajip commented Jan 7, 2020

    New changeset d46dec9 by Vinay Sajip (Miss Islington (bot)) in branch '3.7':
    bpo-39198: Ensure logging global lock is released on exception in isEnabledFor (GH-17689) (GH-17898)
    d46dec9

    @vsajip vsajip closed this as completed Jan 7, 2020
    @vsajip vsajip closed this as completed Jan 7, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life stdlib Python modules in the Lib dir type-crash A hard crash of the interpreter, possibly with a core dump
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @vsajip