Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look up __aenter__ before __aexit__ in the async with statement #83229

Closed
maggyero mannequin opened this issue Dec 14, 2019 · 2 comments
Closed

Look up __aenter__ before __aexit__ in the async with statement #83229

maggyero mannequin opened this issue Dec 14, 2019 · 2 comments
Labels
3.9 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement

Comments

@maggyero
Copy link
Mannequin

maggyero mannequin commented Dec 14, 2019

BPO 39048
Nosy @brettcannon, @rhettinger, @ncoghlan, @asvetlov, @1st1, @maggyero
PRs
  • bpo-39048: Look up __aenter__ before __aexit__ in the async with statement #17609
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-01-14.11:59:46.828>
created_at = <Date 2019-12-14.19:58:37.561>
labels = ['interpreter-core', 'type-feature', '3.9']
title = 'Look up __aenter__ before __aexit__ in the async with statement'
updated_at = <Date 2020-01-14.12:21:10.260>
user = 'https://github.com/maggyero'

    bugs.python.org fields:

    activity = <Date 2020-01-14.12:21:10.260>
actor = 'maggyero'
assignee = 'none'
closed = True
closed_date = <Date 2020-01-14.11:59:46.828>
closer = 'ncoghlan'
components = ['Interpreter Core']
creation = <Date 2019-12-14.19:58:37.561>
creator = 'maggyero'
dependencies = []
files = []
hgrepos = []
issue_num = 39048
keywords = []
message_count = 2.0
messages = ['358403', '359967']
nosy_count = 6.0
nosy_names = ['brett.cannon', 'rhettinger', 'ncoghlan', 'asvetlov', 'yselivanov', 'maggyero']
pr_nums = ['17609']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue39048'
versions = ['Python 3.9']
    @maggyero
    Copy link
    Mannequin Author

    maggyero mannequin commented Dec 14, 2019

    Following https://bugs.python.org/issue27100 which did it for the with statement, what was left to do was to reorder the __aenter__ and __aexit__ method checks for the async with statement.

    I have opened a PR for this here: #17609

    @maggyero maggyero mannequin added 3.8 only security fixes type-bug An unexpected behavior, bug, or error interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Dec 14, 2019
    @maggyero maggyero mannequin changed the title Reorder the __aenter__ and __aexit__ checks for async with bpo-39048: Reorder the __aenter__ and __aexit__ method checks for the async with statement Dec 14, 2019
    @maggyero maggyero mannequin changed the title Reorder the __aenter__ and __aexit__ checks for async with bpo-39048: Reorder the __aenter__ and __aexit__ method checks for the async with statement Dec 14, 2019
    @maggyero maggyero mannequin changed the title bpo-39048: Reorder the __aenter__ and __aexit__ method checks for the async with statement Reorder the __aenter__ and __aexit__ method checks for the async with statement Dec 14, 2019
    @maggyero maggyero mannequin changed the title bpo-39048: Reorder the __aenter__ and __aexit__ method checks for the async with statement Reorder the __aenter__ and __aexit__ method checks for the async with statement Dec 14, 2019
    @terryjreedy terryjreedy added the 3.9 only security fixes label Dec 20, 2019
    @terryjreedy terryjreedy changed the title Reorder the __aenter__ and __aexit__ method checks for the async with statement Reorder __aenter__ & __aexit__ checks for async with statement Dec 20, 2019
    @terryjreedy terryjreedy added the 3.9 only security fixes label Dec 20, 2019
    @terryjreedy terryjreedy changed the title Reorder the __aenter__ and __aexit__ method checks for the async with statement Reorder __aenter__ & __aexit__ checks for async with statement Dec 20, 2019
    @maggyero maggyero mannequin changed the title Reorder __aenter__ & __aexit__ checks for async with statement Change the lookup order of __aenter__ and __aexit__ for async with Jan 13, 2020
    @maggyero maggyero mannequin changed the title Reorder __aenter__ & __aexit__ checks for async with statement Change the lookup order of __aenter__ and __aexit__ for async with Jan 13, 2020
    @ncoghlan
    Copy link
    Contributor

    New changeset 1d1b97a by Nick Coghlan (Géry Ogam) in branch 'master':
    bpo-39048: Look up __aenter__ before __aexit__ in async with (GH-17609)
    1d1b97a

    @ncoghlan ncoghlan removed the 3.8 only security fixes label Jan 14, 2020
    @ncoghlan ncoghlan added type-feature A feature request or enhancement and removed type-bug An unexpected behavior, bug, or error 3.8 only security fixes labels Jan 14, 2020
    @ncoghlan ncoghlan added type-feature A feature request or enhancement and removed type-bug An unexpected behavior, bug, or error labels Jan 14, 2020
    @maggyero maggyero mannequin changed the title Change the lookup order of __aenter__ and __aexit__ for async with Look up __aenter__ before __aexit__ in async with Jan 14, 2020
    @maggyero maggyero mannequin changed the title Change the lookup order of __aenter__ and __aexit__ for async with Look up __aenter__ before __aexit__ in async with Jan 14, 2020
    @maggyero maggyero mannequin changed the title Look up __aenter__ before __aexit__ in async with Look up __aenter__ before __aexit__ in the async with statement Jan 14, 2020
    @maggyero maggyero mannequin changed the title Look up __aenter__ before __aexit__ in async with Look up __aenter__ before __aexit__ in the async with statement Jan 14, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.9 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @ncoghlan @terryjreedy