Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppport TaskWakeupMethWrapper.__self__ to conform asyncio _format_handle logic #83167

Closed
asvetlov opened this issue Dec 6, 2019 · 2 comments
Closed

Suppport TaskWakeupMethWrapper.__self__ to conform asyncio _format_handle logic #83167

asvetlov opened this issue Dec 6, 2019 · 2 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes topic-asyncio

Comments

@asvetlov
Copy link
Contributor

asvetlov commented Dec 6, 2019

BPO 38986
Nosy @asvetlov, @1st1
PRs
  • bpo-38986: Make repr of C accelerated TaskWakeupMethWrapper the same as of pure Python version #17484
  • [3.8] bpo-38986: Make repr of C accelerated TaskWakeupMethWrapper the same as of pure Python version (GH-17484) #17493
  • [3.7] bpo-38986: Make repr of C accelerated TaskWakeupMethWrapper the same as of pure Python version (GH-17484) #17494
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-12-07.11:50:58.189>
created_at = <Date 2019-12-06.13:09:22.582>
labels = ['3.7', '3.8', '3.9', 'expert-asyncio']
title = 'Suppport TaskWakeupMethWrapper.__self__ to conform asyncio _format_handle logic'
updated_at = <Date 2019-12-07.11:50:58.188>
user = 'https://github.com/asvetlov'

    bugs.python.org fields:

    activity = <Date 2019-12-07.11:50:58.188>
actor = 'asvetlov'
assignee = 'none'
closed = True
closed_date = <Date 2019-12-07.11:50:58.189>
closer = 'asvetlov'
components = ['asyncio']
creation = <Date 2019-12-06.13:09:22.582>
creator = 'asvetlov'
dependencies = []
files = []
hgrepos = []
issue_num = 38986
keywords = ['patch']
message_count = 2.0
messages = ['357913', '357915']
nosy_count = 2.0
nosy_names = ['asvetlov', 'yselivanov']
pr_nums = ['17484', '17493', '17494']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue38986'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']
    @asvetlov
    Copy link
    Contributor Author

    asvetlov commented Dec 6, 2019

    _format_handle() behaves differently if handle._callback.__self__ is asyncio.Task instance.

    To follow this logic TaskWakeupMethWrapper from _asynciomodule.c should support the corresponding member.

    The fix is very desired for analyzing slow callbacks, without it the output doesn't point on slow coroutine but mentions <TaskWakeupMethWrapper at 0x...> only.

    See also bpo-38608

    @asvetlov asvetlov added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes topic-asyncio labels Dec 6, 2019
    @asvetlov
    Copy link
    Contributor Author

    asvetlov commented Dec 6, 2019

    For the note: TaskStepMethWrapper has the same fix already, TaskWakeupMethWrapper was accidentally missed.

    @asvetlov asvetlov closed this as completed Dec 7, 2019
    @asvetlov asvetlov closed this as completed Dec 7, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes topic-asyncio
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @asvetlov