Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_stack_overflow (test.test_faulthandler.FaultHandlerTests) is stuck with GCC10 #83146

Closed
marxin mannequin opened this issue Dec 4, 2019 · 11 comments
Closed

test_stack_overflow (test.test_faulthandler.FaultHandlerTests) is stuck with GCC10 #83146

marxin mannequin opened this issue Dec 4, 2019 · 11 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@marxin
Copy link
Mannequin

marxin mannequin commented Dec 4, 2019

BPO 38965
Nosy @vstinner, @ned-deily, @mcepl, @stratakis, @miss-islington, @marxin
PRs
  • bpo-38965: Fix stuck in test_stack_overflow tests. #17462
  • bpo-38965: Fix faulthandler._stack_overflow() on GCC 10 #17467
  • [3.7] bpo-38965: Fix faulthandler._stack_overflow() on GCC 10 (GH-17467) #17468
  • [3.8] bpo-38965: Fix faulthandler._stack_overflow() on GCC 10 (GH-17467) #17469
  • [3.6] bpo-38965: Fix faulthandler._stack_overflow() on GCC 10 (GH-17467) #28079
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-12-04.20:14:09.520>
created_at = <Date 2019-12-04.08:33:20.966>
labels = ['3.7', '3.8', 'type-bug', 'tests', '3.9']
title = 'test_stack_overflow (test.test_faulthandler.FaultHandlerTests) is stuck with GCC10'
updated_at = <Date 2021-08-31.06:30:47.466>
user = 'https://github.com/marxin'

    bugs.python.org fields:

    activity = <Date 2021-08-31.06:30:47.466>
actor = 'ned.deily'
assignee = 'none'
closed = True
closed_date = <Date 2019-12-04.20:14:09.520>
closer = 'vstinner'
components = ['Tests']
creation = <Date 2019-12-04.08:33:20.966>
creator = 'Martin Li\xc5\xa1ka'
dependencies = []
files = []
hgrepos = []
issue_num = 38965
keywords = ['patch']
message_count = 11.0
messages = ['357778', '357824', '357825', '357826', '357827', '357828', '357943', '357950', '376264', '400692', '400693']
nosy_count = 6.0
nosy_names = ['vstinner', 'ned.deily', 'mcepl', 'cstratak', 'miss-islington', 'Martin Li\xc5\xa1ka']
pr_nums = ['17462', '17467', '17468', '17469', '28079']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue38965'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8', 'Python 3.9']
    @marxin
    Copy link
    Mannequin Author

    marxin mannequin commented Dec 4, 2019

    The test-case is stuck after update to GCC 10.
    I've got a patch for that.

    @tirkarthi tirkarthi added tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error labels Dec 4, 2019
    @vstinner
    Copy link
    Member

    vstinner commented Dec 4, 2019

    New changeset 8b78796 by Victor Stinner in branch 'master':
    bpo-38965: Fix faulthandler._stack_overflow() on GCC 10 (GH-17467)
    8b78796

    @vstinner
    Copy link
    Member

    vstinner commented Dec 4, 2019

    Thanks Martin Liška for the bug report and your PR 17462!

    I chose to use volatile instead, since it's already the second time that we have to fix this function for a specific compiler. You abandonned your PR and confrmed that my PR fix your issue with GCC 10, so I merged my PR. Thanks for testing ;-)

    I backported the fix to 3.7 and 3.8 branches.

    @vstinner vstinner added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes labels Dec 4, 2019
    @vstinner vstinner closed this as completed Dec 4, 2019
    @vstinner
    Copy link
    Member

    vstinner commented Dec 4, 2019

    The cool thing is that GCC now also implements tail call optimization!

    @miss-islington
    Copy link
    Contributor

    New changeset 5044c88 by Miss Islington (bot) in branch '3.7':
    bpo-38965: Fix faulthandler._stack_overflow() on GCC 10 (GH-17467)
    5044c88

    @miss-islington
    Copy link
    Contributor

    New changeset f4a21d3 by Miss Islington (bot) in branch '3.8':
    bpo-38965: Fix faulthandler._stack_overflow() on GCC 10 (GH-17467)
    f4a21d3

    @stratakis
    Copy link
    Mannequin

    stratakis mannequin commented Dec 6, 2019

    Would it make sense to also backport this fix to the 3.6 release?

    People compiling 3.6 with gcc 10 will stumble upon that.

    @vstinner
    Copy link
    Member

    vstinner commented Dec 6, 2019

    Would it make sense to also backport this fix to the 3.6 release?

    Sadly, 3.6 no longer accept bugfixes:
    https://devguide.python.org/#status-of-python-branches

    @mcepl
    Copy link
    Mannequin

    mcepl mannequin commented Sep 2, 2020

    3.7 patch applies cleanly even for 3.6.12.

    @ned-deily
    Copy link
    Member

    New changeset 8934bb0 by Miss Islington (bot) in branch '3.6':
    bpo-38965: Fix faulthandler._stack_overflow() on GCC 10 (GH-17467) (GH-28079)
    8934bb0

    @ned-deily
    Copy link
    Member

    I decided to also backport this fix for 3.6.15 since the problem causes test hangs when using GCC 10, as is now that case on one of my test machines. Note that the devguide says: "You should also consider fixing hard-failing tests in open security branches since it is important to be able to run the tests successfully before releasing."

    https://devguide.python.org/devcycle/#security-branches

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @vstinner @tirkarthi @ned-deily @miss-islington