Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code.replace() does not raise audit event #83103

Closed
zooba opened this issue Nov 26, 2019 · 3 comments
Closed

code.replace() does not raise audit event #83103

zooba opened this issue Nov 26, 2019 · 3 comments
Assignees
@zooba
Labels
3.8 only security fixes 3.9 only security fixes

Comments

@zooba
Copy link
Member

zooba commented Nov 26, 2019

BPO 38922
Nosy @zooba, @miss-islington
PRs
  • bpo-38922: Raise code.__new__ audit event when code object replace() is called #17394
  • [3.8] bpo-38922: Raise code.__new__ audit event when code object replace() is called (GH-17394) #17396
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
closed_at = <Date 2019-11-27.00:28:36.906>
created_at = <Date 2019-11-26.20:13:46.181>
labels = ['3.8', '3.9']
title = 'code.replace() does not raise audit event'
updated_at = <Date 2019-11-27.00:46:35.848>
user = 'https://github.com/zooba'

    bugs.python.org fields:

    activity = <Date 2019-11-27.00:46:35.848>
actor = 'miss-islington'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2019-11-27.00:28:36.906>
closer = 'steve.dower'
components = []
creation = <Date 2019-11-26.20:13:46.181>
creator = 'steve.dower'
dependencies = []
files = []
hgrepos = []
issue_num = 38922
keywords = ['patch']
message_count = 3.0
messages = ['357529', '357542', '357543']
nosy_count = 2.0
nosy_names = ['steve.dower', 'miss-islington']
pr_nums = ['17394', '17396']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue38922'
versions = ['Python 3.8', 'Python 3.9']
    @zooba
    Copy link
    Member Author

    zooba commented Nov 26, 2019

    Because code.replace() manually creates a new code object (that is, with arbitrary co_code rather than via the compiler), it should raise code.__new__ with its arguments.

    @zooba zooba added 3.8 only security fixes 3.9 only security fixes labels Nov 26, 2019
    @zooba zooba self-assigned this Nov 26, 2019
    @zooba
    Copy link
    Member Author

    zooba commented Nov 27, 2019

    New changeset c7c01ab by Steve Dower in branch 'master':
    bpo-38922: Raise code.__new__ audit event when code object replace() is called (GH-17394)
    c7c01ab

    @zooba zooba closed this as completed Nov 27, 2019
    @miss-islington
    Copy link
    Contributor

    New changeset 191f94c by Miss Islington (bot) in branch '3.8':
    bpo-38922: Raise code.__new__ audit event when code object replace() is called (GH-17394)
    191f94c

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @zooba zooba

    Labels
    3.8 only security fixes 3.9 only security fixes
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @zooba @miss-islington