Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some unused functions in test suite #83020

Closed
adamchainz mannequin opened this issue Nov 18, 2019 · 2 comments
Closed

Fix some unused functions in test suite #83020

adamchainz mannequin opened this issue Nov 18, 2019 · 2 comments
Labels
type-feature A feature request or enhancement

Comments

@adamchainz
Copy link
Mannequin

adamchainz mannequin commented Nov 18, 2019

BPO 38839
Nosy @brettcannon, @adamchainz
PRs
  • bpo-38839: Fix some unused functions in tests #17189
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-11-19.19:46:02.382>
created_at = <Date 2019-11-18.22:08:25.516>
labels = ['type-feature']
title = 'Fix some unused functions in test suite'
updated_at = <Date 2019-11-19.19:46:02.381>
user = 'https://github.com/adamchainz'

    bugs.python.org fields:

    activity = <Date 2019-11-19.19:46:02.381>
actor = 'brett.cannon'
assignee = 'none'
closed = True
closed_date = <Date 2019-11-19.19:46:02.382>
closer = 'brett.cannon'
components = []
creation = <Date 2019-11-18.22:08:25.516>
creator = 'adamchainz'
dependencies = []
files = []
hgrepos = []
issue_num = 38839
keywords = []
message_count = 2.0
messages = ['356919', '356986']
nosy_count = 2.0
nosy_names = ['brett.cannon', 'adamchainz']
pr_nums = ['17189']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue38839'
versions = []
    @adamchainz
    Copy link
    Mannequin Author

    adamchainz mannequin commented Nov 18, 2019

    Whilst developing a new unused function check for flake8 ( PyCQA/pyflakes#485 ) I ran it against the CPython source code and found some uncalled functions.

    @adamchainz adamchainz mannequin added the type-feature A feature request or enhancement label Nov 18, 2019
    @brettcannon brettcannon changed the title Some unused functions in test suite Fix some unused functions in test suite Nov 19, 2019
    @brettcannon
    Copy link
    Member

    New changeset 892221b by Brett Cannon (Adam Johnson) in branch 'master':
    bpo-38839: Fix some unused functions in tests (GH-17189)
    892221b

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @brettcannon