Commit 6b5b013 ("bpo-26978: Implement pathlib.Path.link_to (Using os.link) (GH-12990)") introduced a new link_to method in pathlib. However, this makes pathlib crash when the 'os' module is missing a 'link' method, as can be seen in the report in this CI test:

https://travis-ci.org/tohojo/flent/jobs/611950252

Just an FYI a raised exception isn't considered a crash. For us a crash is a C-level crash like a segfault.

Right, sure, that makes sense; thanks for clarifying :)

New changeset 111772f by Serhiy Storchaka (Toke Høiland-Jørgensen) in branch 'master':
bpo-38811: Check for presence of os.link method in pathlib. (GH-17170)
111772f

The change failed on x86 Windows7 3.x buildbot:
https://buildbot.python.org/all/#/builders/58/builds/3257

Moreover, PR 17170 was merged whereas the CLA was not signed. So I created PR 17219 to revert the change to fix the Windows 7 failure and to wait until the CLA is signed.

======================================================================
ERROR: test_symlink_to_not_implemented (test.test_pathlib.PathTest)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\test\test_pathlib.py", line 2031, in test_symlink_to_not_implemented
    link.symlink_to(target)
  File "D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\pathlib.py", line 1395, in symlink_to
    self._accessor.symlink(target, self, target_is_directory)
OSError: [WinError 1314] A required privilege is not held by the client: 'D:\\cygwin\\home\\db3l\\buildarea\\3.x.bolen-windows7\\build\\build\\test_python_848\\test_python_worker_2032\\@test_2032_tmp\\fileA' -> 'D:\\cygwin\\home\\db3l\\buildarea\\3.x.bolen-windows7\\build\\build\\test_python_848\\test_python_worker_2032\\@test_2032_tmp\\dirA\\linkAA'

======================================================================
ERROR: test_symlink_to_not_implemented (test.test_pathlib.WindowsPathTest)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\test\test_pathlib.py", line 2031, in test_symlink_to_not_implemented
    link.symlink_to(target)
  File "D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\pathlib.py", line 1395, in symlink_to
    self._accessor.symlink(target, self, target_is_directory)
OSError: [WinError 1314] A required privilege is not held by the client: 'D:\\cygwin\\home\\db3l\\buildarea\\3.x.bolen-windows7\\build\\build\\test_python_848\\test_python_worker_2032\\@test_2032_tmp\\fileA' -> 'D:\\cygwin\\home\\db3l\\buildarea\\3.x.bolen-windows7\\build\\build\\test_python_848\\test_python_worker_2032\\@test_2032_tmp\\dirA\\linkAA'

New changeset 59c8088 by Victor Stinner in branch 'master':
Revert "bpo-38811: Check for presence of os.link method in pathlib. (GH-17170)" (bpo-17219)
59c8088

New changeset 092435e by Victor Stinner (Toke Høiland-Jørgensen) in branch 'master':
bpo-38811: Check for presence of os.link method in pathlib (GH-17225)
092435e

Thanks Toke Høiland-Jørgensen! I merged your fix.

I don't really get why the Debian/Ubuntu image on Travis CI didn't get os.link() function, but I'm not really intersted to dig into this question. It's fine to simply skip the feature if it's not available, we do that in many places in Python.

I asked Toke Høiland-Jørgensen to revert his changes about os.symlink(): the pathlib code to handle missing os.symlink() seems to be broken, but it also seems like Python no longer support platforms without os.symlink(). Only old Windows version didn't support os.symlink(), but Python don't support these versions anymore.

I merged the os.link() change into master and made a 3.8 backport which will be merged automatically soon.

I close the issue.

New changeset 8d0f369 by Miss Islington (bot) in branch '3.8':
bpo-38811: Check for presence of os.link method in pathlib (GH-17225)
8d0f369

If someone cares about the missing os.symlink code path: please open a separated issue.