Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDLE calltips may not properly close on KeyboardInterrupt #82973

Closed
ZackerySpytz mannequin opened this issue Nov 14, 2019 · 8 comments
Closed

IDLE calltips may not properly close on KeyboardInterrupt #82973

ZackerySpytz mannequin opened this issue Nov 14, 2019 · 8 comments
Assignees
Labels
3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes topic-IDLE type-bug An unexpected behavior, bug, or error

Comments

@ZackerySpytz
Copy link
Mannequin

ZackerySpytz mannequin commented Nov 14, 2019

BPO 38792
Nosy @rhettinger, @terryjreedy, @taleinat, @ZackerySpytz, @miss-islington, @iritkatriel
PRs
  • bpo-38792: Remove IDLE shell calltip before new prompt. #17150
  • [3.8] bpo-38792: Remove IDLE shell calltip before new prompt. (GH-17150) #18287
  • [3.7] bpo-38792: Remove IDLE shell calltip before new prompt. (GH-17150) #18288
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/terryjreedy'
    closed_at = <Date 2020-10-10.14:51:11.272>
    created_at = <Date 2019-11-14.06:47:31.079>
    labels = ['3.8', 'expert-IDLE', 'type-bug', '3.7', '3.9']
    title = 'IDLE calltips may not properly close on KeyboardInterrupt'
    updated_at = <Date 2020-10-10.14:51:11.272>
    user = 'https://github.com/ZackerySpytz'

    bugs.python.org fields:

    activity = <Date 2020-10-10.14:51:11.272>
    actor = 'terry.reedy'
    assignee = 'terry.reedy'
    closed = True
    closed_date = <Date 2020-10-10.14:51:11.272>
    closer = 'terry.reedy'
    components = ['IDLE']
    creation = <Date 2019-11-14.06:47:31.079>
    creator = 'ZackerySpytz'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 38792
    keywords = ['patch']
    message_count = 8.0
    messages = ['356580', '356590', '361003', '361087', '361090', '361091', '361092', '378406']
    nosy_count = 6.0
    nosy_names = ['rhettinger', 'terry.reedy', 'taleinat', 'ZackerySpytz', 'miss-islington', 'iritkatriel']
    pr_nums = ['17150', '18287', '18288']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue38792'
    versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']

    @ZackerySpytz
    Copy link
    Mannequin Author

    ZackerySpytz mannequin commented Nov 14, 2019

    If a KeyboardInterrupt occurs while an IDLE calltip is being displayed,
    the calltip will persist until a new calltip event. The calltip should
    be removed immediately in this case.

    @ZackerySpytz ZackerySpytz mannequin added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes labels Nov 14, 2019
    @ZackerySpytz ZackerySpytz mannequin added topic-IDLE type-bug An unexpected behavior, bug, or error labels Nov 14, 2019
    @taleinat
    Copy link
    Contributor

    Hi Zack, thanks for this!

    This doesn't go far enough, actually; we should make sure to close the calltip in other cases too, such as restarting the shell or hitting return to running a statement / block.

    @terryjreedy
    Copy link
    Member

    I verified problem for KeyboardInterrupt and RestartShell but not for a newline that actually runs the statement. In my experiments, if a newline in inserted instead of running, the cursor remains within a call and the calltip should not disappear.

    @terryjreedy
    Copy link
    Member

    New changeset bfdeaa3 by Zackery Spytz in branch 'master':
    bpo-38792: Remove IDLE shell calltip before new prompt. (bpo-17150)
    bfdeaa3

    @miss-islington
    Copy link
    Contributor

    New changeset 8d02114 by Miss Islington (bot) in branch '3.7':
    bpo-38792: Remove IDLE shell calltip before new prompt. (GH-17150)
    8d02114

    @miss-islington
    Copy link
    Contributor

    New changeset 83d3202 by Miss Islington (bot) in branch '3.8':
    bpo-38792: Remove IDLE shell calltip before new prompt. (GH-17150)
    83d3202

    @terryjreedy
    Copy link
    Member

    On the issue, Tal pointed out that SyntaxError leaves a calltip after a new >>> prompt.  Also fixed.

    @iritkatriel
    Copy link
    Member

    This seems complete, can it be closed?

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes topic-IDLE type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    4 participants