Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that os.fork is not allowed in subinterpreters #82959

Closed
phmc mannequin opened this issue Nov 12, 2019 · 5 comments
Closed

Document that os.fork is not allowed in subinterpreters #82959

phmc mannequin opened this issue Nov 12, 2019 · 5 comments
Labels
3.8 only security fixes 3.9 only security fixes docs Documentation in the Doc dir

Comments

@phmc
Copy link
Mannequin

phmc mannequin commented Nov 12, 2019

BPO 38778
Nosy @ericsnowcurrently, @phmc, @miss-islington
PRs
  • bpo-38778: Document that os.fork is not allowed in subinterpreters #17123
  • [3.8] bpo-38778: Document that os.fork is not allowed in subinterpreters (GH-17123) #17179
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2019-11-15.21:39:07.153>
    created_at = <Date 2019-11-12.14:38:20.507>
    labels = ['3.8', '3.9', 'docs']
    title = 'Document that os.fork is not allowed in subinterpreters'
    updated_at = <Date 2019-11-15.21:39:07.152>
    user = 'https://github.com/phmc'

    bugs.python.org fields:

    activity = <Date 2019-11-15.21:39:07.152>
    actor = 'eric.snow'
    assignee = 'docs@python'
    closed = True
    closed_date = <Date 2019-11-15.21:39:07.153>
    closer = 'eric.snow'
    components = ['Documentation']
    creation = <Date 2019-11-12.14:38:20.507>
    creator = 'pconnell'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 38778
    keywords = ['patch']
    message_count = 5.0
    messages = ['356459', '356693', '356704', '356719', '356721']
    nosy_count = 4.0
    nosy_names = ['docs@python', 'eric.snow', 'pconnell', 'miss-islington']
    pr_nums = ['17123', '17179']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue38778'
    versions = ['Python 3.8', 'Python 3.9']

    @phmc
    Copy link
    Mannequin Author

    phmc mannequin commented Nov 12, 2019

    Add a comment to the os.fork docs to note that forking from a subinterpreter is no longer allowed (see bpo-34651)

    @phmc phmc mannequin added the 3.8 only security fixes label Nov 12, 2019
    @phmc phmc mannequin assigned docspython Nov 12, 2019
    @phmc phmc mannequin added the docs Documentation in the Doc dir label Nov 12, 2019
    @miss-islington
    Copy link
    Contributor

    New changeset b220300 by Miss Islington (bot) (Phil Connell) in branch 'master':
    bpo-38778: Document that os.fork is not allowed in subinterpreters (GH-17123)
    b220300

    @ericsnowcurrently
    Copy link
    Member

    Nice work, Phil. We need a backport to 3.8, but the miss-islington bot is having trouble with it. [1] Either we can try flipping the "needs backport to 3.8" label again or you could create a backport PR yourself (like miss-islington suggested). If you do that then be sure to request a review from me. :)

    [1] #17123 (comment)

    @ericsnowcurrently ericsnowcurrently added the 3.9 only security fixes label Nov 15, 2019
    @miss-islington
    Copy link
    Contributor

    New changeset a4be5aa by Miss Islington (bot) in branch '3.8':
    bpo-38778: Document that os.fork is not allowed in subinterpreters (GH-17123)
    a4be5aa

    @ericsnowcurrently
    Copy link
    Member

    Flipping the label one more time did the trick. Thanks again, Phil!

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.8 only security fixes 3.9 only security fixes docs Documentation in the Doc dir
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants