Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add signal.pidfd_send_signal #82893

Closed
benjaminp opened this issue Nov 6, 2019 · 5 comments
Closed

add signal.pidfd_send_signal #82893

benjaminp opened this issue Nov 6, 2019 · 5 comments
Labels
3.9 only security fixes stdlib Python modules in the Lib dir

Comments

@benjaminp
Copy link
Contributor

BPO 38712
Nosy @benjaminp, @njsmith
PRs
  • closes bpo-38712: Add signal.pidfd_send_signal. #17070
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-11-20.04:39:20.824>
created_at = <Date 2019-11-06.05:08:46.932>
labels = ['library', '3.9']
title = 'add signal.pidfd_send_signal'
updated_at = <Date 2019-11-20.04:39:20.822>
user = 'https://github.com/benjaminp'

    bugs.python.org fields:

    activity = <Date 2019-11-20.04:39:20.822>
actor = 'benjamin.peterson'
assignee = 'none'
closed = True
closed_date = <Date 2019-11-20.04:39:20.824>
closer = 'benjamin.peterson'
components = ['Library (Lib)']
creation = <Date 2019-11-06.05:08:46.932>
creator = 'benjamin.peterson'
dependencies = []
files = []
hgrepos = []
issue_num = 38712
keywords = ['patch']
message_count = 4.0
messages = ['356091', '356093', '356101', '357028']
nosy_count = 2.0
nosy_names = ['benjamin.peterson', 'njs']
pr_nums = ['17070']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue38712'
versions = ['Python 3.9']
    @benjaminp
    Copy link
    Contributor Author

    Add signal.pidfd_send_signal, which will wrap the Linux 5.1 syscall of the same name.

    @benjaminp benjaminp added 3.9 only security fixes stdlib Python modules in the Lib dir labels Nov 6, 2019
    @njsmith
    Copy link
    Contributor

    njsmith commented Nov 6, 2019

    I guess a bikeshed question is whether it should be os.pidfd_send_signal (like os.kill) or signal.pidfd_send_signal (like signal.pthread_kill).

    I don't actually care either way myself :-)

    @benjaminp
    Copy link
    Contributor Author

    Yes, I thought about that a bit. I choose signal because:

    1. signal already has some specialized functions that send signals pthread_kill and raise_signal.
    2. If we every do want to implement the third parameter of pidfd_send_signal, the signal module already defines a siginfo structseq.
    3. (least convincing) os/posix has way too much stuff. I generally think that we should strive to find a good home for new OS-level functionality that isn't the os module.

    @benjaminp
    Copy link
    Contributor Author

    New changeset 7483451 by Benjamin Peterson in branch 'master':
    closes bpo-38712: Add signal.pidfd_send_signal. (GH-17070)
    7483451

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @GiovanniHD201E
    Copy link

    How I do signalisation on W10?

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.9 only security fixes stdlib Python modules in the Lib dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @benjaminp @njsmith @GiovanniHD201E