Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WWW-Authenticate qop="auth,auth-int" rejected by urllib #82867

Closed
PypeBros mannequin opened this issue Nov 4, 2019 · 4 comments
Closed

WWW-Authenticate qop="auth,auth-int" rejected by urllib #82867

PypeBros mannequin opened this issue Nov 4, 2019 · 4 comments
Assignees
Labels
3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes type-bug An unexpected behavior, bug, or error

Comments

@PypeBros
Copy link
Mannequin

PypeBros mannequin commented Nov 4, 2019

BPO 38686
Nosy @orsenthil, @miss-islington, @PypeBros
PRs
  • bpo-38686: fix HTTP Digest handling in request.py #17045
  • [3.8] bpo-38686: fix HTTP Digest handling in request.py (GH-17045) #17357
  • [3.7] bpo-38686: fix HTTP Digest handling in request.py (GH-17045) #17358
  • bpo-39548: Fix handling of 'WWW-Authenticate' header for Digest Auth #18338
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/orsenthil'
    closed_at = <Date 2019-11-22.23:41:58.095>
    created_at = <Date 2019-11-04.15:27:24.939>
    labels = ['3.8', 'type-bug', '3.7', '3.9']
    title = 'WWW-Authenticate qop="auth,auth-int" rejected by urllib'
    updated_at = <Date 2020-02-06.12:43:26.840>
    user = 'https://github.com/PypeBros'

    bugs.python.org fields:

    activity = <Date 2020-02-06.12:43:26.840>
    actor = 'Stephen Balousek'
    assignee = 'orsenthil'
    closed = True
    closed_date = <Date 2019-11-22.23:41:58.095>
    closer = 'orsenthil'
    components = []
    creation = <Date 2019-11-04.15:27:24.939>
    creator = 'PypeBros'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 38686
    keywords = ['patch']
    message_count = 4.0
    messages = ['355952', '357338', '357339', '357343']
    nosy_count = 3.0
    nosy_names = ['orsenthil', 'miss-islington', 'PypeBros']
    pr_nums = ['17045', '17357', '17358', '18338']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue38686'
    versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']

    @PypeBros
    Copy link
    Mannequin Author

    PypeBros mannequin commented Nov 4, 2019

    in urllib/request.py,
    when trying to use HTTP Digest Authentication
    with a server that replies with WWW-Authenticate: Digest
    where qop="auth,auth-int" rather than mere qop="auth"

    the connection fails to establish with a "qop 'auth,auth-int' is not supported" error message.

    qop="auth,auth-int" should imho be accepted according to the qop-options` rule in §3.2.1 of https://www.ietf.org/rfc/rfc2617.txt, given that 'auth' is supported by urllib/request.py

    @PypeBros PypeBros mannequin added the 3.7 (EOL) end of life label Nov 4, 2019
    @orsenthil orsenthil self-assigned this Nov 13, 2019
    @orsenthil orsenthil added the 3.8 only security fixes label Nov 22, 2019
    @orsenthil
    Copy link
    Member

    New changeset 14a89c4 by Senthil Kumaran (PypeBros) in branch 'master':
    bpo-38686: fix HTTP Digest handling in request.py (bpo-17045)
    14a89c4

    @orsenthil orsenthil added 3.9 only security fixes 3.7 (EOL) end of life and removed 3.7 (EOL) end of life labels Nov 22, 2019
    @miss-islington
    Copy link
    Contributor

    New changeset b9e5547 by Miss Islington (bot) in branch '3.8':
    bpo-38686: fix HTTP Digest handling in request.py (GH-17045)
    b9e5547

    @miss-islington
    Copy link
    Contributor

    New changeset 07432c3 by Miss Islington (bot) in branch '3.7':
    bpo-38686: fix HTTP Digest handling in request.py (GH-17045)
    07432c3

    @orsenthil orsenthil added the type-bug An unexpected behavior, bug, or error label Nov 22, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants