Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal include files missing on Windows #82700

Closed
zooba opened this issue Oct 18, 2019 · 5 comments
Closed

Internal include files missing on Windows #82700

zooba opened this issue Oct 18, 2019 · 5 comments
Assignees
@zooba
Labels
3.8 only security fixes 3.9 only security fixes build The build process and cross-build OS-windows

Comments

@zooba
Copy link
Member

zooba commented Oct 18, 2019

BPO 38519
Nosy @pfmoore, @tjguk, @zware, @zooba, @ZackerySpytz, @miss-islington
PRs
  • bpo-38519: Internal include files missing on Windows #16921
  • [3.8] bpo-38519: Internal include files missing on Windows (GH-16921) #16966
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
closed_at = <Date 2020-02-25.18:23:02.959>
created_at = <Date 2019-10-18.18:30:38.215>
labels = ['build', '3.8', '3.9', 'OS-windows']
title = 'Internal include files missing on Windows'
updated_at = <Date 2020-02-25.18:23:02.958>
user = 'https://github.com/zooba'

    bugs.python.org fields:

    activity = <Date 2020-02-25.18:23:02.958>
actor = 'steve.dower'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2020-02-25.18:23:02.959>
closer = 'steve.dower'
components = ['Windows']
creation = <Date 2019-10-18.18:30:38.215>
creator = 'steve.dower'
dependencies = []
files = []
hgrepos = []
issue_num = 38519
keywords = ['patch']
message_count = 5.0
messages = ['354914', '354915', '355353', '355568', '355571']
nosy_count = 6.0
nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'steve.dower', 'ZackerySpytz', 'miss-islington']
pr_nums = ['16921', '16966']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue38519'
versions = ['Python 3.8', 'Python 3.9']
    @zooba
    Copy link
    Member Author

    zooba commented Oct 18, 2019

    The include/internal directory is not being included in the packages published to nuget.org or the Microsoft Store.

    This prevents some advanced users from being able to compile against these packages.

    @zooba zooba added 3.8 only security fixes 3.9 only security fixes labels Oct 18, 2019
    @zooba zooba self-assigned this Oct 18, 2019
    @zooba zooba added OS-windows build The build process and cross-build labels Oct 18, 2019
    @zooba
    Copy link
    Member Author

    zooba commented Oct 18, 2019

    If someone wants to fix this before I do, the change goes in PC/layout/main.py to remove the filter for directories named "internal" - we shouldn't need a filter there at all now that we include everything in the distro.

    @ZackerySpytz
    Copy link
    Mannequin

    ZackerySpytz mannequin commented Oct 25, 2019

    Hi, Steve. I've created a PR for this.

    @zooba
    Copy link
    Member Author

    zooba commented Oct 28, 2019

    New changeset edb172a by Steve Dower (Zackery Spytz) in branch 'master':
    bpo-38519: Internal include files missing on Windows (GH-16921)
    edb172a

    @miss-islington
    Copy link
    Contributor

    New changeset 07eee64 by Miss Skeleton (bot) in branch '3.8':
    bpo-38519: Internal include files missing on Windows (GH-16921)
    07eee64

    @zooba zooba closed this as completed Feb 25, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @zooba zooba

    Labels
    3.8 only security fixes 3.9 only security fixes build The build process and cross-build OS-windows
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @zooba @miss-islington