Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python needs higher resolution app/menu icons #82620

Closed
hroncok mannequin opened this issue Oct 10, 2019 · 16 comments
Closed

Python needs higher resolution app/menu icons #82620

hroncok mannequin opened this issue Oct 10, 2019 · 16 comments
Labels
3.8 only security fixes 3.9 only security fixes 3.10 only security fixes topic-IDLE

Comments

@hroncok
Copy link
Mannequin

hroncok mannequin commented Oct 10, 2019

BPO 38439
Nosy @terryjreedy, @vstinner, @serhiy-storchaka, @zooba, @hroncok, @miss-islington
PRs
  • bpo-38439: Add 256px IDLE icon #17473
  • [3.8] bpo-38439: Add 256px IDLE icon (GH-17473) #19646
  • [3.7] bpo-38439: Add 256px IDLE icon (GH-17473) #19647
  • bpo-38439: Add 256px IDLE icon to the .ico, drop gifs from it #19648
  • bpo-38439: Update the Windows Store package's icons for IDLE. #22817
  • [3.8] bpo-38439: Add 256px IDLE icon to the .ico, drop gifs from it (GH-19648) #22823
  • [3.9] bpo-38439: Add 256px IDLE icon to the .ico, drop gifs from it (GH-19648) #22824
  • [3.9] bpo-38439: Update the Windows Store package's icons for IDLE. Artwork by Andrew Clover (GH-22817) #22825
  • [3.8] bpo-38439: Update the Windows Store package's icons for IDLE. Artwork by Andrew Clover (GH-22817) #22826
    		•
    Files
  • idle.png: Screenshot of the icon on GNOME
  • python.png
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-10-21.16:19:38.879>
created_at = <Date 2019-10-10.23:14:55.639>
labels = ['expert-IDLE', '3.8', '3.9', '3.10']
title = 'Python needs higher resolution app/menu icons'
updated_at = <Date 2020-10-21.16:19:38.878>
user = 'https://github.com/hroncok'

    bugs.python.org fields:

    activity = <Date 2020-10-21.16:19:38.878>
actor = 'steve.dower'
assignee = 'none'
closed = True
closed_date = <Date 2020-10-21.16:19:38.879>
closer = 'steve.dower'
components = ['IDLE']
creation = <Date 2019-10-10.23:14:55.639>
creator = 'hroncok'
dependencies = []
files = ['48655', '48758']
hgrepos = []
issue_num = 38439
keywords = ['patch']
message_count = 16.0
messages = ['354415', '354422', '357846', '357849', '357852', '361392', '366985', '366987', '366989', '379120', '379137', '379144', '379145', '379146', '379215', '379216']
nosy_count = 6.0
nosy_names = ['terry.reedy', 'vstinner', 'serhiy.storchaka', 'steve.dower', 'hroncok', 'miss-islington']
pr_nums = ['17473', '19646', '19647', '19648', '22817', '22823', '22824', '22825', '22826']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue38439'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']
    @hroncok
    Copy link
    Mannequin Author

    hroncok mannequin commented Oct 10, 2019

    See the attached screenshot. All the GNOME apps have scalable icons, only the IDLE icon is scaled up from 48x48 pixels.

    I've found similar bpo-32129, but apparently the accepted resolution was to change a bit of code somewhere, not to provide higher resolution icons.

    @hroncok hroncok mannequin assigned terryjreedy Oct 10, 2019
    @hroncok hroncok mannequin added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes topic-IDLE labels Oct 10, 2019
    @terryjreedy
    Copy link
    Member

    I think you misunderstood bpo-32129. It was specific to macOS Aqua systems. On Windows and generally on Linux, window title bars have a little icon on the left end (at least on Windows). IDLE uses the tcl/tk GUI framework and by default, on these systems, tk windows have a generic tk icon at the left end. (At least that is the position on Windows.) bpo-20406 replaced the tk icon with versions of the Python app icon.

    On mac Aqua, tk window title bars do not have an icon. Somehow Mac, Aqua, and tk interact so that the replacement icon instead replaced Apple's version of the Python app (menu) icon, which is different from the *nix/Windows python app icon. This was unintended and a bug. The fix was to not execute the replacement code on Mac Aqua systems.

    Your png shows the Python app icon used for IDLE as a Python application. It is the same one used for Python applications on the Windows taskbar, including but not limited to IDLE. I agreed on bpo-32129 that it would be good if someone contributed higher resolution versions. But it is not specifically an IDLE issue. I will say more tomorrow.

    @terryjreedy terryjreedy changed the title IDLE menu icon is blurry on GNOME Python needs higher resolution app/menu icons Oct 11, 2019
    @terryjreedy terryjreedy removed their assignment Oct 11, 2019
    @hroncok
    Copy link
    Mannequin Author

    hroncok mannequin commented Dec 5, 2019

    At https://mgabrail.wordpress.com/2011/08/19/5-reasons-why-you-should-learn-python-programming/ I have found https://mgabrail.files.wordpress.com/2011/08/python.png - I have no idea what is the license of this file or where it originated from, but this looks fairly like the icon in question.

    Google images reveal more liek it, usually resized or jpeged.

    @hroncok
    Copy link
    Mannequin Author

    hroncok mannequin commented Dec 5, 2019

    https://bugs.python.org/issue1490384
    https://www.doxdesk.com/software/py/pyicons.html

    @vstinner
    Copy link
    Member

    vstinner commented Dec 5, 2019

    Oh ok, I confirm that #17473 is an icon drew by Andrew Clover.

    https://www.doxdesk.com/file/software/py/v/pyicons-full-0.4.zip from https://www.doxdesk.com/software/py/pyicons.html contains py0032.png which is the same picture (same pixels), but the MD5 is different because metadata are different.

    That's the website of Andrew Clover: https://www.doxdesk.com/personal/

    @zooba
    Copy link
    Member

    zooba commented Feb 5, 2020

    Copying my comment from the PR:

    Could someone with the SVG also create 44x44 and 150x150 sized versions? (Like the pythonx44.png and pythonx150.png files in PC/icons.)

    These are the sizes used for the tiles created by the Microsoft Store installer, and referenced from PC\layout\support\appxmanifest.py (search for pythonwx to find the current IDLE and pythonw references).

    @terryjreedy
    Copy link
    Member

    New changeset 3a69f3c by Miro Hrončok in branch 'master':
    bpo-38439: Add 256px IDLE icon (GH-17473)
    3a69f3c

    @miss-islington
    Copy link
    Contributor

    New changeset abdfb3b by Miss Islington (bot) in branch '3.7':
    bpo-38439: Add 256px IDLE icon (GH-17473)
    abdfb3b

    @miss-islington
    Copy link
    Contributor

    New changeset 3a55450 by Miss Islington (bot) in branch '3.8':
    bpo-38439: Add 256px IDLE icon (GH-17473)
    3a55450

    @zooba
    Copy link
    Member

    zooba commented Oct 20, 2020

    New changeset faddc74 by Miro Hrončok in branch 'master':
    bpo-38439: Add 256px IDLE icon to the .ico, drop gifs from it (GH-19648)
    faddc74

    @zooba
    Copy link
    Member

    zooba commented Oct 20, 2020

    New changeset 6d883fb by Steve Dower in branch 'master':
    bpo-38439: Update the Windows Store package's icons for IDLE. Artwork by Andrew Clover (GH-22817)
    6d883fb

    @miss-islington
    Copy link
    Contributor

    New changeset 333782a by Miss Skeleton (bot) in branch '3.8':
    bpo-38439: Update the Windows Store package's icons for IDLE. Artwork by Andrew Clover (GH-22817)
    333782a

    @miss-islington
    Copy link
    Contributor

    New changeset d84e411 by Miss Skeleton (bot) in branch '3.8':
    bpo-38439: Add 256px IDLE icon to the .ico, drop gifs from it (GH-19648)
    d84e411

    @miss-islington
    Copy link
    Contributor

    New changeset d12afba by Miss Skeleton (bot) in branch '3.9':
    bpo-38439: Update the Windows Store package's icons for IDLE. Artwork by Andrew Clover (GH-22817)
    d12afba

    @miss-islington
    Copy link
    Contributor

    New changeset 871c6cc by Miss Skeleton (bot) in branch '3.9':
    bpo-38439: Add 256px IDLE icon to the .ico, drop gifs from it (GH-19648)
    871c6cc

    @zooba
    Copy link
    Member

    zooba commented Oct 21, 2020

    This seems complete to me, but feel free to reopen if it is not.

    @zooba zooba added 3.10 only security fixes and removed 3.7 (EOL) end of life labels Oct 21, 2020
    @zooba zooba closed this as completed Oct 21, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes 3.9 only security fixes 3.10 only security fixes topic-IDLE
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @vstinner @zooba @terryjreedy @miss-islington