Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

single-argument form of -isysroot should be supported #82541

Closed
jmroot mannequin opened this issue Oct 3, 2019 · 7 comments
Closed

single-argument form of -isysroot should be supported #82541

jmroot mannequin opened this issue Oct 3, 2019 · 7 comments
Assignees
@ned-deily
Labels
3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes OS-mac stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@jmroot
Copy link
Mannequin

jmroot mannequin commented Oct 3, 2019

BPO 38360
Nosy @ronaldoussoren, @ned-deily, @merwok, @jmroot, @dstufft, @miss-islington
PRs
  • bpo-38360: macOS: support alternate form of -isysroot flag #16480
  • [3.7] bpo-38360: macOS: support alternate form of -isysroot flag (GH-16480) #19657
  • [3.8] bpo-38360: macOS: support alternate form of -isysroot flag (GH-16480) #19658
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/ned-deily'
closed_at = <Date 2020-04-22.07:53:20.460>
created_at = <Date 2019-10-03.11:20:54.494>
labels = ['OS-mac', 'type-bug', '3.8', '3.9', '3.7', 'library']
title = 'single-argument form of -isysroot should be supported'
updated_at = <Date 2020-04-22.17:21:50.180>
user = 'https://github.com/jmroot'

    bugs.python.org fields:

    activity = <Date 2020-04-22.17:21:50.180>
actor = 'ned.deily'
assignee = 'ned.deily'
closed = True
closed_date = <Date 2020-04-22.07:53:20.460>
closer = 'ned.deily'
components = ['Distutils', 'macOS']
creation = <Date 2019-10-03.11:20:54.494>
creator = 'jmr'
dependencies = []
files = []
hgrepos = []
issue_num = 38360
keywords = []
message_count = 7.0
messages = ['353838', '356046', '366990', '366991', '366997', '367017', '367027']
nosy_count = 6.0
nosy_names = ['ronaldoussoren', 'ned.deily', 'eric.araujo', 'jmr', 'dstufft', 'miss-islington']
pr_nums = ['16480', '19657', '19658']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue38360'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']
    @jmroot
    Copy link
    Mannequin Author

    jmroot mannequin commented Oct 3, 2019

    The path associated with the -isysroot compiler flag can be supplied either as a separate argument or in the same argument as -isysroot itself. The places in library code that do special handling of this flag should support both forms, but currently only support the two separate arguments form. This means that the flag may not be removed when pointing to a nonexistent SDK or when a different SDK is specified in the user's CFLAGS, and at worst a ValueError is raised in compiler_fixup.

    @jmroot jmroot mannequin added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes stdlib Python modules in the Lib dir OS-mac type-bug An unexpected behavior, bug, or error labels Oct 3, 2019
    @jmroot
    Copy link
    Mannequin Author

    jmroot mannequin commented Nov 5, 2019

    Ping?

    @ned-deily
    Copy link
    Member

    New changeset b310700 by Joshua Root in branch 'master':
    bpo-38360: macOS: support alternate form of -isysroot flag (GH-16480)
    b310700

    @ned-deily
    Copy link
    Member

    Thanks for the PR! This seems like a borderline feature rather than a bug so, unless there is a compelling reason to backport it to 3.8.x, I'm just going to push it to master for release in 3.9.0 (as of alpha 6).

    @ned-deily ned-deily removed 3.7 (EOL) end of life 3.8 only security fixes labels Apr 22, 2020
    @ned-deily ned-deily self-assigned this Apr 22, 2020
    @jmroot
    Copy link
    Mannequin Author

    jmroot mannequin commented Apr 22, 2020

    That ValueError I mentioned causes build failures for extension modules whenever the CFLAGS in sysconfig contains an -isysroot flag in the single arg form. We ran into it a lot in MacPorts on Mojave and Catalina. So I would consider it a bug, and would prefer to backport to all branches that are open for bug fixes.

    @miss-islington
    Copy link
    Contributor

    New changeset e7f8684 by Miss Islington (bot) in branch '3.7':
    bpo-38360: macOS: support alternate form of -isysroot flag (GH-16480)
    e7f8684

    @miss-islington
    Copy link
    Contributor

    New changeset 4a6da0b by Miss Islington (bot) in branch '3.8':
    bpo-38360: macOS: support alternate form of -isysroot flag (GH-16480)
    4a6da0b

    @ned-deily ned-deily added 3.7 (EOL) end of life 3.8 only security fixes labels Apr 22, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @ned-deily ned-deily

    Labels
    3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes OS-mac stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @ned-deily @miss-islington