Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup the path configuration implementation code (getpath.c) #82534

Closed
vstinner opened this issue Oct 2, 2019 · 13 comments
Closed

Cleanup the path configuration implementation code (getpath.c) #82534

vstinner opened this issue Oct 2, 2019 · 13 comments
Labels
3.9 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@vstinner
Copy link
Member

vstinner commented Oct 2, 2019

BPO 38353
Nosy @vstinner
PRs
  • bpo-38353: Cleanup includes in the internal C API #16548
  • bpo-38353: Fix calculate_argv0_path() for symlinks #16549
  • bpo-38353: Fix compiler warning in pycore_initconfig.h #16570
  • bpo-38353: Add subfunctions to getpath.c #16572
  • bpo-38353: Fix compiler warning in internal headers #16573
  • bpo-38353: Rework ismodule() in getpath.c #16574
  • bpo-38353: getpath.c uses dynamically allocated strings #16582
  • bpo-38353: getpath.c: allocates strings on the heap #16585
  • bpo-38353: Simplify calculate_pybuilddir() #16614
  • bpo-38353: Fix typos in calculate_argv0_path_framework() #16695
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-03-25.18:02:10.023>
created_at = <Date 2019-10-02.21:12:43.206>
labels = ['interpreter-core', '3.9']
title = 'Cleanup the path configuration implementation code (getpath.c)'
updated_at = <Date 2020-03-25.18:02:10.023>
user = 'https://github.com/vstinner'

    bugs.python.org fields:

    activity = <Date 2020-03-25.18:02:10.023>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2020-03-25.18:02:10.023>
closer = 'vstinner'
components = ['Interpreter Core']
creation = <Date 2019-10-02.21:12:43.206>
creator = 'vstinner'
dependencies = []
files = []
hgrepos = []
issue_num = 38353
keywords = ['patch']
message_count = 13.0
messages = ['353774', '353777', '353879', '353885', '353890', '353891', '353892', '353893', '353946', '353962', '354077', '354369', '354379']
nosy_count = 1.0
nosy_names = ['vstinner']
pr_nums = ['16548', '16549', '16570', '16572', '16573', '16574', '16582', '16585', '16614', '16695']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue38353'
versions = ['Python 3.9']
    @vstinner
    Copy link
    Member Author

    vstinner commented Oct 2, 2019

    Place holder issue for changes related to path configuration cleanup changes (Modules/getpath.c).

    @vstinner vstinner added 3.9 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Oct 2, 2019
    @vstinner
    Copy link
    Member Author

    vstinner commented Oct 2, 2019

    New changeset 61691d8 by Victor Stinner in branch 'master':
    bpo-38353: Cleanup includes in the internal C API (GH-16548)
    61691d8

    @vstinner
    Copy link
    Member Author

    vstinner commented Oct 3, 2019

    New changeset 86ec5c6 by Victor Stinner in branch 'master':
    bpo-38353: Fix calculate_argv0_path() for symlinks (GH-16549)
    86ec5c6

    @vstinner
    Copy link
    Member Author

    vstinner commented Oct 3, 2019

    New changeset c515b57 by Victor Stinner in branch 'master':
    bpo-38353: Fix compiler warning in pycore_initconfig.h (GH-16570)
    c515b57

    @vstinner
    Copy link
    Member Author

    vstinner commented Oct 4, 2019

    On my Fedora 30, GCC doesn't complain on "typedef struct pyruntimestate _PyRuntimeState;". But clang on macOS emits a warning, saying that it's C11-only feature. So I modified the internal header files to use "struct pyruntimestate" instead, to avoid any compilation issue.

    @vstinner
    Copy link
    Member Author

    vstinner commented Oct 4, 2019

    New changeset e982d8b by Victor Stinner in branch 'master':
    bpo-38353: Fix compiler warning in internal headers (GH-16573)
    e982d8b

    @vstinner
    Copy link
    Member Author

    vstinner commented Oct 4, 2019

    New changeset 03a8a56 by Victor Stinner in branch 'master':
    bpo-38353: Add subfunctions to getpath.c (GH-16572)
    03a8a56

    @vstinner
    Copy link
    Member Author

    vstinner commented Oct 4, 2019

    New changeset f0c8579 by Victor Stinner in branch 'master':
    bpo-38353: Rework ismodule() in getpath.c (GH-16574)
    f0c8579

    @vstinner
    Copy link
    Member Author

    vstinner commented Oct 4, 2019

    New changeset abd7cd8 by Victor Stinner in branch 'master':
    bpo-38353: getpath.c uses dynamically allocated strings (GH-16582)
    abd7cd8

    @vstinner
    Copy link
    Member Author

    vstinner commented Oct 4, 2019

    New changeset c02b41b by Victor Stinner in branch 'master':
    bpo-38353: getpath.c: allocates strings on the heap (GH-16585)
    c02b41b

    @vstinner
    Copy link
    Member Author

    vstinner commented Oct 7, 2019

    New changeset b96145a by Victor Stinner in branch 'master':
    bpo-38353: Simplify calculate_pybuilddir() (GH-16614)
    b96145a

    @vstinner
    Copy link
    Member Author

    New changeset b6e0fc7 by Victor Stinner in branch 'master':
    bpo-38353: Fix typos in calculate_argv0_path_framework() (GH-16695)
    b6e0fc7

    @vstinner
    Copy link
    Member Author

    I created this issue to attempt to modify _PyPathConfig to use PyWideStringList for module_search_paths, to support ":" character in a path. It would fix bpo-31210.

    See also bpo-12989.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.9 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs)
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @vstinner