Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SMTPNotSupportedError in the exports of smtplib #82522

Closed
rockwelln mannequin opened this issue Oct 1, 2019 · 5 comments
Closed

Add SMTPNotSupportedError in the exports of smtplib #82522

rockwelln mannequin opened this issue Oct 1, 2019 · 5 comments
Labels
3.7 (EOL) end of life topic-email type-feature A feature request or enhancement

Comments

@rockwelln
Copy link
Mannequin

rockwelln mannequin commented Oct 1, 2019

BPO 38341
Nosy @warsaw, @bitdancer, @maxking, @rockwelln, @miss-islington
PRs
  • bpo-38341: Add SMTPNotSupportedError in the exports of smtplib #16525
  • [3.7] bpo-38341: Add SMTPNotSupportedError in the exports of smtplib (GH-16525) #16590
  • [3.8] bpo-38341: Add SMTPNotSupportedError in the exports of smtplib (GH-16525) #16721
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-10-12.16:29:37.998>
created_at = <Date 2019-10-01.20:50:46.945>
labels = ['type-feature', '3.7', 'expert-email']
title = 'Add SMTPNotSupportedError in the exports of smtplib'
updated_at = <Date 2019-10-12.16:29:37.997>
user = 'https://github.com/rockwelln'

    bugs.python.org fields:

    activity = <Date 2019-10-12.16:29:37.997>
actor = 'maxking'
assignee = 'none'
closed = True
closed_date = <Date 2019-10-12.16:29:37.998>
closer = 'maxking'
components = ['email']
creation = <Date 2019-10-01.20:50:46.945>
creator = 'Norman.Denayer'
dependencies = []
files = []
hgrepos = []
issue_num = 38341
keywords = ['patch']
message_count = 5.0
messages = ['353712', '353981', '353982', '354533', '354534']
nosy_count = 5.0
nosy_names = ['barry', 'r.david.murray', 'maxking', 'Norman.Denayer', 'miss-islington']
pr_nums = ['16525', '16590', '16721']
priority = 'normal'
resolution = None
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue38341'
versions = ['Python 3.7']
    @rockwelln
    Copy link
    Mannequin Author

    rockwelln mannequin commented Oct 1, 2019

    Long story short:
    smtplib.SMTPNotSupportedError seems the only exception not present in __all__ variable exposed by smtplib.py

    Context:
    I currently face an issue running mypy on one of my module:
    ...tools/email.py:46: error: Module has no attribute "SMTPNotSupportedError"
    except smtplib.SMTPNotSupportedError:

    Digging into the context of this error, I note this exception is not exposed in the list __all__.

    Regards,
    Norman

    @rockwelln rockwelln mannequin added 3.7 (EOL) end of life topic-email type-feature A feature request or enhancement labels Oct 1, 2019
    @maxking
    Copy link
    Contributor

    maxking commented Oct 5, 2019

    It seems that SMTPNotSupportedError is publicly documented, it should be a part of __all__.

    @maxking
    Copy link
    Contributor

    maxking commented Oct 5, 2019

    New changeset 3faf826 by Abhilash Raj (nde) in branch 'master':
    bpo-38341: Add SMTPNotSupportedError in the exports of smtplib (bpo-16525)
    3faf826

    @miss-islington
    Copy link
    Contributor

    New changeset 1da648a by Miss Islington (bot) in branch '3.8':
    bpo-38341: Add SMTPNotSupportedError in the exports of smtplib (GH-16525)
    1da648a

    @miss-islington
    Copy link
    Contributor

    New changeset cb580d6 by Miss Islington (bot) in branch '3.7':
    bpo-38341: Add SMTPNotSupportedError in the exports of smtplib (GH-16525)
    cb580d6

    @maxking maxking closed this as completed Oct 12, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life topic-email type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @maxking @miss-islington