Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_ssl: replace 3DES with AES encrypted private keys #82452

Closed
tiran opened this issue Sep 25, 2019 · 4 comments
Closed

test_ssl: replace 3DES with AES encrypted private keys #82452

tiran opened this issue Sep 25, 2019 · 4 comments
Assignees
@tiran
Labels
3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes performance Performance or resource usage tests Tests in the Lib/test dir

Comments

@tiran
Copy link
Member

tiran commented Sep 25, 2019

BPO 38271
Nosy @tiran, @miss-islington
PRs
  • bpo-38271: encrypt private key test files with AES256 #16385
  • [3.8] bpo-38271: encrypt private key test files with AES256 (GH-16385) #16395
  • [3.7] bpo-38271: encrypt private key test files with AES256 (GH-16385) #16396
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/tiran'
closed_at = <Date 2019-09-25.21:44:52.058>
created_at = <Date 2019-09-25.11:10:15.731>
labels = ['3.8', '3.7', 'tests', '3.9', 'performance']
title = 'test_ssl: replace 3DES with AES encrypted private keys'
updated_at = <Date 2019-09-25.21:44:52.057>
user = 'https://github.com/tiran'

    bugs.python.org fields:

    activity = <Date 2019-09-25.21:44:52.057>
actor = 'christian.heimes'
assignee = 'christian.heimes'
closed = True
closed_date = <Date 2019-09-25.21:44:52.058>
closer = 'christian.heimes'
components = ['Tests']
creation = <Date 2019-09-25.11:10:15.731>
creator = 'christian.heimes'
dependencies = []
files = []
hgrepos = []
issue_num = 38271
keywords = ['patch']
message_count = 4.0
messages = ['353173', '353217', '353219', '353220']
nosy_count = 2.0
nosy_names = ['christian.heimes', 'miss-islington']
pr_nums = ['16385', '16395', '16396']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'resource usage'
url = 'https://bugs.python.org/issue38271'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']
    @tiran
    Copy link
    Member Author

    tiran commented Sep 25, 2019

    test_ssl uses two encrypted private key files to verify the password hook. The private key files are currently encrypted with 3DES (DES-EDE3-CBC). The algorithm is very old and blocked by some crypto policies. Let's use AES256 instead. AES is mandatory in all supported OpenSSL versions.

    @tiran tiran added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes tests Tests in the Lib/test dir performance Performance or resource usage labels Sep 25, 2019
    @tiran tiran self-assigned this Sep 25, 2019
    @miss-islington
    Copy link
    Contributor

    New changeset bfd0c96 by Miss Islington (bot) (Christian Heimes) in branch 'master':
    bpo-38271: encrypt private key test files with AES256 (GH-16385)
    bfd0c96

    @miss-islington
    Copy link
    Contributor

    New changeset 585798f by Miss Islington (bot) in branch '3.7':
    bpo-38271: encrypt private key test files with AES256 (GH-16385)
    585798f

    @miss-islington
    Copy link
    Contributor

    New changeset 4267e8f by Miss Islington (bot) in branch '3.8':
    bpo-38271: encrypt private key test files with AES256 (GH-16385)
    4267e8f

    @tiran tiran closed this as completed Sep 25, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @tiran tiran

    Labels
    3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes performance Performance or resource usage tests Tests in the Lib/test dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @tiran @miss-islington