Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memoryview.size is redundant #48077

Closed
benjaminp opened this issue Sep 9, 2008 · 5 comments
Closed

memoryview.size is redundant #48077

benjaminp opened this issue Sep 9, 2008 · 5 comments
Labels
deferred-blocker interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@benjaminp
Copy link
Contributor

BPO 3827
Nosy @brettcannon, @amauryfa, @pitrou, @benjaminp
Files
  • remove_size_attr.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2008-09-10.21:47:23.219>
created_at = <Date 2008-09-09.22:18:41.915>
labels = ['interpreter-core', 'deferred-blocker']
title = 'memoryview.size is redundant'
updated_at = <Date 2008-09-11.00:26:45.379>
user = 'https://github.com/benjaminp'

    bugs.python.org fields:

    activity = <Date 2008-09-11.00:26:45.379>
actor = 'amaury.forgeotdarc'
assignee = 'none'
closed = True
closed_date = <Date 2008-09-10.21:47:23.219>
closer = 'benjamin.peterson'
components = ['Interpreter Core']
creation = <Date 2008-09-09.22:18:41.915>
creator = 'benjamin.peterson'
dependencies = []
files = ['11450']
hgrepos = []
issue_num = 3827
keywords = ['patch', 'needs review']
message_count = 5.0
messages = ['72929', '72932', '72938', '72988', '72999']
nosy_count = 5.0
nosy_names = ['brett.cannon', 'teoliphant', 'amaury.forgeotdarc', 'pitrou', 'benjamin.peterson']
pr_nums = []
priority = 'deferred blocker'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue3827'
versions = ['Python 3.0']
    @benjaminp
    Copy link
    Contributor Author

    memoryview.size will always be the same as len(view), so one or the
    other should go. (probably .size)

    @benjaminp benjaminp added release-blocker interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Sep 9, 2008
    @pitrou
    Copy link
    Member

    pitrou commented Sep 9, 2008

    The patch is ok to me.

    @brettcannon
    Copy link
    Member

    Since this is a 3.0 thing I am dropping it down to a deferred blocker.

    @benjaminp
    Copy link
    Contributor Author

    Fixed in r66374.

    @amauryfa
    Copy link
    Member

    This causes test_ctypes to fail.
    r66382 corrects the test to use len(v) instead of v.size

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    deferred-blocker interpreter-core (Objects, Python, Grammar, and Parser dirs)
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @brettcannon @benjaminp @amauryfa @pitrou