Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase Code Coverage for SharedMemory and ShareableListe #82350

Closed
vinay0410 mannequin opened this issue Sep 14, 2019 · 3 comments
Closed

Increase Code Coverage for SharedMemory and ShareableListe #82350

vinay0410 mannequin opened this issue Sep 14, 2019 · 3 comments
Labels
3.9 only security fixes tests Tests in the Lib/test dir

Comments

@vinay0410
Copy link
Mannequin

vinay0410 mannequin commented Sep 14, 2019

BPO 38169
Nosy @corona10, @vinay0410
PRs
  • bpo-38169: Increase code coverage for SharedMemory and ShareableList #16139
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-07-19.13:36:13.730>
created_at = <Date 2019-09-14.07:44:31.901>
labels = ['tests', '3.9']
title = 'Increase Code Coverage for SharedMemory and ShareableListe'
updated_at = <Date 2020-07-19.13:36:13.730>
user = 'https://github.com/vinay0410'

    bugs.python.org fields:

    activity = <Date 2020-07-19.13:36:13.730>
actor = 'corona10'
assignee = 'none'
closed = True
closed_date = <Date 2020-07-19.13:36:13.730>
closer = 'corona10'
components = ['Tests']
creation = <Date 2019-09-14.07:44:31.901>
creator = 'vinay0410'
dependencies = []
files = []
hgrepos = []
issue_num = 38169
keywords = ['patch']
message_count = 3.0
messages = ['352420', '373957', '373964']
nosy_count = 2.0
nosy_names = ['corona10', 'vinay0410']
pr_nums = ['16139']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue38169'
versions = ['Python 3.9']
    @vinay0410
    Copy link
    Mannequin Author

    vinay0410 mannequin commented Sep 14, 2019

    Add Tests for SharedMemory and ShareableList. I have also added a check to prevent users from creating shared memory of size 0, because after creating mmap will throw error while memory mapping she of size 0.

    @vinay0410 vinay0410 mannequin added 3.9 only security fixes tests Tests in the Lib/test dir labels Sep 14, 2019
    @vinay0410
    Copy link
    Mannequin Author

    vinay0410 mannequin commented Jul 19, 2020

    Remove Check to prevent creating shared_memory with size 0. Will create a different issue for the same.

    @corona10
    Copy link
    Member

    New changeset bfd0fbd by Vinay Sharma in branch 'master':
    bpo-38169: Increase code coverage for SharedMemory and ShareableList (GH-16139)
    bfd0fbd

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.9 only security fixes tests Tests in the Lib/test dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @corona10