Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove copy of fast PBKDF2 algorithm #82315

Closed
tiran opened this issue Sep 12, 2019 · 3 comments
Closed

Remove copy of fast PBKDF2 algorithm #82315

tiran opened this issue Sep 12, 2019 · 3 comments
Assignees
@tiran
Labels
3.8 only security fixes 3.9 only security fixes extension-modules C modules in the Modules dir type-feature A feature request or enhancement

Comments

@tiran
Copy link
Member

tiran commented Sep 12, 2019

BPO 38134
Nosy @gpshead, @tiran, @miss-islington
PRs
  • bpo-38134: Remove PKBDF2_HMAC_fast from _hashopenssl #16028
  • [3.8] bpo-38134: Remove PKBDF2_HMAC_fast from _hashopenssl (GH-16028) #16034
  • bpo-38137: Re-add OpenSSL 1.0.2 compat #16051
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/tiran'
closed_at = <Date 2019-09-12.12:25:32.513>
created_at = <Date 2019-09-12.11:13:37.010>
labels = ['extension-modules', 'type-feature', '3.8', '3.9']
title = 'Remove copy of fast PBKDF2 algorithm'
updated_at = <Date 2019-09-12.14:12:11.545>
user = 'https://github.com/tiran'

    bugs.python.org fields:

    activity = <Date 2019-09-12.14:12:11.545>
actor = 'christian.heimes'
assignee = 'christian.heimes'
closed = True
closed_date = <Date 2019-09-12.12:25:32.513>
closer = 'christian.heimes'
components = ['Extension Modules']
creation = <Date 2019-09-12.11:13:37.010>
creator = 'christian.heimes'
dependencies = []
files = []
hgrepos = []
issue_num = 38134
keywords = ['patch']
message_count = 3.0
messages = ['352111', '352132', '352136']
nosy_count = 3.0
nosy_names = ['gregory.p.smith', 'christian.heimes', 'miss-islington']
pr_nums = ['16028', '16034', '16051']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue38134'
versions = ['Python 3.8', 'Python 3.9']
    @tiran
    Copy link
    Member Author

    tiran commented Sep 12, 2019

    bpo bpo-18582 added a C implementation of PBKDF2 algorithm. Back then Python still supported OpenSSL versions with a slow version of PBKDF2-HMAC. Nowadays all supported OpenSSL versions contain an optimized version of the password derivation algorithm.

    @tiran tiran added 3.8 only security fixes 3.9 only security fixes labels Sep 12, 2019
    @tiran tiran self-assigned this Sep 12, 2019
    @tiran tiran added extension-modules C modules in the Modules dir type-feature A feature request or enhancement labels Sep 12, 2019
    @gpshead
    Copy link
    Member

    gpshead commented Sep 12, 2019

    New changeset 64117e0 by Gregory P. Smith (Christian Heimes) in branch 'master':
    bpo-38134: Remove PKBDF2_HMAC_fast from _hashopenssl (GH-16028)
    64117e0

    @miss-islington
    Copy link
    Contributor

    New changeset 80e3365 by Miss Islington (bot) in branch '3.8':
    bpo-38134: Remove PKBDF2_HMAC_fast from _hashopenssl (GH-16028)
    80e3365

    @tiran tiran closed this as completed Sep 12, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @tiran tiran

    Labels
    3.8 only security fixes 3.9 only security fixes extension-modules C modules in the Modules dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @gpshead @tiran @miss-islington