Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2to3 urllib fixer: missing fix for urllib.getproxies #82261

Closed
shiyuchong mannequin opened this issue Sep 10, 2019 · 2 comments
Closed

2to3 urllib fixer: missing fix for urllib.getproxies #82261

shiyuchong mannequin opened this issue Sep 10, 2019 · 2 comments
Labels
3.9 only security fixes topic-2to3 type-bug An unexpected behavior, bug, or error

Comments

@shiyuchong
Copy link
Mannequin

shiyuchong mannequin commented Sep 10, 2019

BPO 38080
Nosy @pablogsal, @shiyuchong, @robertpro
PRs
  • bpo-38080 [2to3] Added getproxies to urllib fixes #16167
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-03-12.00:00:20.198>
created_at = <Date 2019-09-10.06:14:06.727>
labels = ['type-bug', 'expert-2to3', '3.9']
title = '2to3 urllib fixer: missing fix for urllib.getproxies'
updated_at = <Date 2020-03-12.00:00:20.194>
user = 'https://github.com/shiyuchong'

    bugs.python.org fields:

    activity = <Date 2020-03-12.00:00:20.194>
actor = 'pablogsal'
assignee = 'none'
closed = True
closed_date = <Date 2020-03-12.00:00:20.198>
closer = 'pablogsal'
components = ['2to3 (2.x to 3.x conversion tool)']
creation = <Date 2019-09-10.06:14:06.727>
creator = 'shiyuchong'
dependencies = []
files = []
hgrepos = []
issue_num = 38080
keywords = ['patch']
message_count = 2.0
messages = ['351576', '363988']
nosy_count = 3.0
nosy_names = ['pablogsal', 'shiyuchong', 'robertpro']
pr_nums = ['16167']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue38080'
versions = ['Python 3.9']
    @shiyuchong
    Copy link
    Mannequin Author

    shiyuchong mannequin commented Sep 10, 2019

    urllib.getproxies can be converted to urllib.request.getproxies, and their documentation looks the same.
    but in fix_urllib.py and my real test, it is ignored. I do not know why 2to3 does nothing. Is it a bug?

    @shiyuchong shiyuchong mannequin added 3.7 (EOL) end of life topic-2to3 type-bug An unexpected behavior, bug, or error labels Sep 10, 2019
    @pablogsal
    Copy link
    Member

    New changeset 276a84a by José Roberto Meza Cabrera in branch 'master':
    bpo-38080: Added "getproxies" to urllib fixes in the 2to3 tool (GH-16167)
    276a84a

    @pablogsal pablogsal added 3.9 only security fixes and removed 3.7 (EOL) end of life labels Mar 12, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.9 only security fixes topic-2to3 type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @pablogsal