Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCompiler has_function displays warning #82146

Closed
madebr mannequin opened this issue Aug 27, 2019 · 7 comments
Closed

CCompiler has_function displays warning #82146

madebr mannequin opened this issue Aug 27, 2019 · 7 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@madebr
Copy link
Mannequin

madebr mannequin commented Aug 27, 2019

BPO 37965
Nosy @benjaminp, @merwok, @dstufft, @miss-islington, @madebr
PRs
  • closes bpo-37965: Fix compiler warning of distutils CCompiler.test_function. #15560
  • [3.8] closes bpo-37965: Fix compiler warning of distutils CCompiler.test_function. (GH-15560) #15561
  • [3.7] closes bpo-37965: Fix compiler warning of distutils CCompiler.test_function. (GH-15560) #15562
  • [2.7] closes bpo-37965: Fix compiler warning of distutils CCompiler.test_function. (GH-15560) #15563
    		•
    Files
  • 0001-Fix-compiler-warning-of-distutils-CCompiler.test_fun.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-08-28.17:11:12.172>
created_at = <Date 2019-08-27.20:47:14.738>
labels = ['3.7', '3.8', 'type-bug', 'library', '3.9']
title = 'CCompiler has_function displays warning'
updated_at = <Date 2019-08-28.17:37:41.014>
user = 'https://github.com/madebr'

    bugs.python.org fields:

    activity = <Date 2019-08-28.17:37:41.014>
actor = 'miss-islington'
assignee = 'none'
closed = True
closed_date = <Date 2019-08-28.17:11:12.172>
closer = 'miss-islington'
components = ['Distutils']
creation = <Date 2019-08-27.20:47:14.738>
creator = 'maarten'
dependencies = []
files = ['48563']
hgrepos = []
issue_num = 37965
keywords = ['patch']
message_count = 7.0
messages = ['350645', '350649', '350661', '350676', '350679', '350680', '350681']
nosy_count = 5.0
nosy_names = ['benjamin.peterson', 'eric.araujo', 'dstufft', 'miss-islington', 'maarten']
pr_nums = ['15560', '15561', '15562', '15563']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue37965'
versions = ['Python 3.5', 'Python 3.6', 'Python 3.7', 'Python 3.8', 'Python 3.9']
    @madebr
    Copy link
    Mannequin Author

    madebr mannequin commented Aug 27, 2019

    When using the has_function method of a CCompiler object,
    the compiler will emit a warning because the main function has no return type specified.

    cpython/Lib/distutils/ccompiler.py

    Lines 784 to 786 in 8c9e9b0

    main (int argc, char **argv) {
    %s();
    }

    This warning is emitted:
    /tmp/clockq2_azlzj.c:2:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
    2 | main (int argc, char **argv) {
    | ^~~~

    This happens under Linux, gcc 9

    @madebr madebr mannequin added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Aug 27, 2019
    @benjaminp
    Copy link
    Contributor

    seems like a good patch. Can you submit a PR?

    @madebr
    Copy link
    Mannequin Author

    madebr mannequin commented Aug 28, 2019

    I have submitted a PR to github:
    #15560

    @miss-islington
    Copy link
    Contributor

    New changeset 55aabee by Miss Islington (bot) (Anonymous Maarten) in branch 'master':
    closes bpo-37965: Fix compiler warning of distutils CCompiler.test_function. (GH-15560)
    55aabee

    @benjaminp
    Copy link
    Contributor

    New changeset 23985c6 by Benjamin Peterson (Miss Islington (bot)) in branch '3.8':
    closes bpo-37965: Fix compiler warning of distutils CCompiler.test_function. (GH-15561)
    23985c6

    @miss-islington
    Copy link
    Contributor

    New changeset 0229b56 by Miss Islington (bot) in branch '2.7':
    closes bpo-37965: Fix compiler warning of distutils CCompiler.test_function. (GH-15560)
    0229b56

    @miss-islington
    Copy link
    Contributor

    New changeset ea48966 by Miss Islington (bot) in branch '3.7':
    closes bpo-37965: Fix compiler warning of distutils CCompiler.test_function. (GH-15560)
    ea48966

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @benjaminp @miss-islington