Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python uninstaller leave registry entries #48028

Closed
donovaly mannequin opened this issue Sep 4, 2008 · 13 comments
Closed

python uninstaller leave registry entries #48028

donovaly mannequin opened this issue Sep 4, 2008 · 13 comments
Labels
easy topic-installation type-bug An unexpected behavior, bug, or error

Comments

@donovaly
Copy link
Mannequin

donovaly mannequin commented Sep 4, 2008

BPO 3778
Nosy @loewis, @tebeka, @bitdancer, @zooba

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2021-10-20.18:19:37.790>
created_at = <Date 2008-09-04.21:08:13.802>
labels = ['easy', 'type-bug', 'expert-installation']
title = 'python uninstaller leave registry entries'
updated_at = <Date 2021-10-20.18:19:37.789>
user = 'https://bugs.python.org/donovaly'

bugs.python.org fields:

activity = <Date 2021-10-20.18:19:37.789>
actor = 'steve.dower'
assignee = 'none'
closed = True
closed_date = <Date 2021-10-20.18:19:37.790>
closer = 'steve.dower'
components = ['Installation']
creation = <Date 2008-09-04.21:08:13.802>
creator = 'donovaly'
dependencies = []
files = []
hgrepos = []
issue_num = 3778
keywords = ['easy']
message_count = 13.0
messages = ['72520', '102116', '102121', '102126', '102141', '102165', '102166', '102167', '102169', '102275', '187307', '187365', '194082']
nosy_count = 6.0
nosy_names = ['loewis', 'tebeka', 'techtonik', 'donovaly', 'r.david.murray', 'steve.dower']
pr_nums = []
priority = 'low'
resolution = 'out of date'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue3778'
versions = ['Python 3.1', 'Python 2.7', 'Python 3.2']
@donovaly
Copy link
Mannequin Author

donovaly mannequin commented Sep 4, 2008

  • install Python 2.5.2 using the Windows installer
  • now uninstall Python

Result: The uninstaller doesn't remove the registry folder
HKLM\SOFTWARE\Python
and all its subfolders.

@donovaly donovaly mannequin added the topic-installation label Sep 4, 2008
@techtonik
Copy link
Mannequin

techtonik mannequin commented Apr 1, 2010

Confirmed 2.6.5 installer leaves "HKLM\SOFTWARE\Python\PythonCore\2.6\Modules" on install/uninstall without \2.6\ key.

I propose to mark it as 'low' priority.

@bitdancer
Copy link
Member

I imagine this affects 3.1 and 3.2 as well, but I haven't added them to versions since that hasn't been confirmed.

@bitdancer bitdancer added easy type-bug An unexpected behavior, bug, or error labels Apr 1, 2010
@briancurtin
Copy link
Member

Confirmed on 3.x.

@loewis
Copy link
Mannequin

loewis mannequin commented Apr 1, 2010

FWIW: contributions are welcome.

@voidspace
Copy link
Contributor

Isn't there an issue around having multiple versions of Python installed? The top level folder should only be removed if the version of Python being uninstalled is the last installed Python. This means executing code on uninstall and doesn't seem worth the effort.

If I'm correct in this then I would suggest closing as wontfix.

@techtonik
Copy link
Mannequin

techtonik mannequin commented Apr 2, 2010

The top level should be removed only when it is empty after Python that is being uninstalled removed its own branch.

@techtonik
Copy link
Mannequin

techtonik mannequin commented Apr 2, 2010

There should be a "function" to remove key if empty.

BTW, what software is used to create (un)installer and where is Python code for it?

@briancurtin
Copy link
Member

See PC/_msi.c, Lib/msilib, and Tools/msi

@loewis
Copy link
Mannequin

loewis mannequin commented Apr 3, 2010

I think Installer has features to remove registry keys with no subkeys; we probably would need to declare that we create these keys, and then Installer might remove them automatically.

@BreamoreBoy
Copy link
Mannequin

BreamoreBoy mannequin commented Apr 18, 2013

I don't think this is worth the bother. I've checked my registry and the only entry under HKLM\SOFTWARE\Python is PythonCore, under this are the following.

2.6
Help
Pythonwin Reference
C:\Python26\Lib\site-packages\PyWin32.chm
Modules
2.7
Help
Pythonwin Reference
C:\Python27\Lib\site-packages\PyWin32.chm
Modules
3.1
Modules
3.2
Modules
3.3
Help
Main Python Documentation
C:\Python33\Doc\python331.chm
Install Path
Install Group
Python 3.3
Modules
PythonPath
C:\Python33\Lib;C:\Python33\DLLs

Only 3.3 is live on my machine. Clearly the pythonwin keys aren't our responsibility. It's hardly a lot of data anyway so why worry about it? Yes I'm aware that it's good practice to clean up after yourself but in this case is it really worth the effort?

@techtonik
Copy link
Mannequin

techtonik mannequin commented Apr 19, 2013

What is the reason for not following the good practice? Is it so hard to fix?

@loewis
Copy link
Mannequin

loewis mannequin commented Aug 1, 2013

Nobody has contributed a patch in five years, so it apparently is pretty hard.

@zooba zooba closed this as completed Oct 20, 2021
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy topic-installation type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@voidspace @briancurtin @bitdancer @zooba