Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDLE: Re-order run menu #81929

Closed
terryjreedy opened this issue Aug 3, 2019 · 8 comments
Closed

IDLE: Re-order run menu #81929

terryjreedy opened this issue Aug 3, 2019 · 8 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes type-feature A feature request or enhancement

Comments

@terryjreedy
Copy link
Member

BPO 37748
Nosy @rhettinger, @terryjreedy, @taleinat, @csabella, @miss-islington
PRs
  • bpo-37748: Re-order the Run menu. #15115
  • [3.8] bpo-37748: Re-order the Run menu. (GH-15115) #15119
  • [3.7] bpo-37748: Re-order the Run menu. (GH-15115) #15120
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2019-08-04.21:46:11.819>
    created_at = <Date 2019-08-03.04:48:25.190>
    labels = ['3.8', 'type-feature', '3.7', '3.9']
    title = 'IDLE: Re-order run menu'
    updated_at = <Date 2019-08-04.21:46:11.818>
    user = 'https://github.com/terryjreedy'

    bugs.python.org fields:

    activity = <Date 2019-08-04.21:46:11.818>
    actor = 'terry.reedy'
    assignee = 'none'
    closed = True
    closed_date = <Date 2019-08-04.21:46:11.819>
    closer = 'terry.reedy'
    components = []
    creation = <Date 2019-08-03.04:48:25.190>
    creator = 'terry.reedy'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 37748
    keywords = ['patch']
    message_count = 8.0
    messages = ['348940', '348958', '348966', '348967', '348972', '349003', '349005', '349006']
    nosy_count = 5.0
    nosy_names = ['rhettinger', 'terry.reedy', 'taleinat', 'cheryl.sabella', 'miss-islington']
    pr_nums = ['15115', '15119', '15120']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue37748'
    versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']

    @terryjreedy
    Copy link
    Member Author

    With the addition of Run Customized, the run menu looks like

    Python Shell
    Check Module
    Run Module
    Run... Customized

    This order resulted from Check and Run Module originally being implemented as extensions, which forced them to be below Python Shell. The situation was similar with Format Paragraph being forced below less commonly used options on the Format menu. It is now at the top.
    Run... Customized was tacked on below, without worrying about the appropriate order for the menu..

    On issue bpo-37627, Raymond Hettinger suggested "Move the [new] menu option up by one so that the regular F5 "run" is last -- learners we having a hard time finding and mouse targeting the more commonly used regular "run" option. The result would be

    Python Shell
    Check Module
    Run... Customized
    Run Module

    I would rather make Run Module, the most commonly used option even more prominent by putting it at the top, perhaps by reversing the order.

    Run Module
    Run... Customized
    Check Module
    Python Shell

    With Run Module at the top, remaining items could be ordered by logic, and to me, the above is plausible on that score, or by use, perhaps putting the second-most used at the bottom. I suspect that this will be Run Customized. To me, Check Module is useless, though I can imagine situation when it is not. Python Shell is only needed when there is no shell and one does not want to make one appear by running a module. To switch to an existing Shell, on should use the Windows menu. Anyway, another candidate is

    Run Module
    Check Module
    Python Shell
    Run... Customized

    @terryjreedy terryjreedy added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes type-feature A feature request or enhancement labels Aug 3, 2019
    @taleinat
    Copy link
    Contributor

    taleinat commented Aug 3, 2019

    Perhaps we should use a separator to differentiate between things that run in the shell and those that don't, e.g. as following:

    Run Module
    Run... Customized
    Python Shell
    -------------
    Check Module

    @terryjreedy
    Copy link
    Member Author

    Run Module and Run Customized both run Check Module first. All three involve the code in the particular editor. Restarting Shell is not editor specific, so I see *it* as the oddball.

    The proposed Run Checker bpo-21880, would involve the editor code, might or might not Check Module first, but would not run in or involve Shell at all. It might be a good candidate for the last position. If it were added, I think my first option, Run Module ... Python Shell would be better.

    @taleinat
    Copy link
    Contributor

    taleinat commented Aug 3, 2019

    Ah, my bad, I mixed up "Check Module" with the proposed external checkers feature.

    Anyways, I'm +1 on this reordering, but have no opinion on the specifics.

    @rhettinger
    Copy link
    Contributor

    +1 for the proposed reverse ordering:

    Run Module
    Run... Customized
    Check Module
    Python Shell

    @terryjreedy
    Copy link
    Member Author

    New changeset 1407029 by Terry Jan Reedy in branch 'master':
    bpo-37748: Re-order the Run menu. (GH-15115)
    1407029

    @miss-islington
    Copy link
    Contributor

    New changeset 9c95fc7 by Miss Islington (bot) in branch '3.8':
    bpo-37748: Re-order the Run menu. (GH-15115)
    9c95fc7

    @miss-islington
    Copy link
    Contributor

    New changeset a96f036 by Miss Islington (bot) in branch '3.7':
    bpo-37748: Re-order the Run menu. (GH-15115)
    a96f036

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    4 participants