Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"make clean" should remove PGO task data #81906

Closed
nascheme opened this issue Jul 30, 2019 · 2 comments
Closed

"make clean" should remove PGO task data #81906

nascheme opened this issue Jul 30, 2019 · 2 comments
Labels
build The build process and cross-build type-feature A feature request or enhancement

Comments

@nascheme
Copy link
Member

BPO 37725
Nosy @nascheme, @DinoV
PRs
  • bpo-37725: have "make clean" remove PGO task data #15033
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-09-30.20:47:35.672>
created_at = <Date 2019-07-30.23:23:49.626>
labels = ['type-feature', 'build']
title = '"make clean" should remove PGO task data'
updated_at = <Date 2019-09-30.20:47:35.672>
user = 'https://github.com/nascheme'

    bugs.python.org fields:

    activity = <Date 2019-09-30.20:47:35.672>
actor = 'nascheme'
assignee = 'none'
closed = True
closed_date = <Date 2019-09-30.20:47:35.672>
closer = 'nascheme'
components = ['Build']
creation = <Date 2019-07-30.23:23:49.626>
creator = 'nascheme'
dependencies = []
files = []
hgrepos = []
issue_num = 37725
keywords = ['patch']
message_count = 2.0
messages = ['348773', '351602']
nosy_count = 2.0
nosy_names = ['nascheme', 'dino.viehland']
pr_nums = ['15033']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue37725'
versions = []
    @nascheme
    Copy link
    Member Author

    I find it annoying and surprising that "make clean" does not remove the PGO data. If you change a source file, running "make clean" and "make" should result in a newly built executable, IMHO. As it is now, you usually get a confusing build failure (PGO data is out of date).

    The fix is fairly easy. Make a new target that does what "clean" currently does. Have the PGO build call that when it needs to preserve the PGO data. Introduce a new "clean" target that does what the old clean did and also removes the PGO data.

    Changing the build system is fraught with danger but I think this is a fairly safe change. The current behavior is quite annoying, IMHO.

    @nascheme nascheme added build The build process and cross-build type-feature A feature request or enhancement labels Jul 30, 2019
    @DinoV
    Copy link
    Contributor

    DinoV commented Sep 10, 2019

    New changeset c6bbcd2 by Dino Viehland (Neil Schemenauer) in branch 'master':
    bpo-37725: have "make clean" remove PGO task data (bpo-15033)
    c6bbcd2

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    build The build process and cross-build type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @DinoV @nascheme