Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regrtest: re-run failed tests in subprocesses #81892

Closed
vstinner opened this issue Jul 29, 2019 · 3 comments
Closed

regrtest: re-run failed tests in subprocesses #81892

vstinner opened this issue Jul 29, 2019 · 3 comments
Labels
3.9 only security fixes tests Tests in the Lib/test dir

Comments

@vstinner
Copy link
Member

BPO 37711
Nosy @vstinner

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2019-07-29.23:44:36.211>
labels = ['tests', '3.9']
title = 'regrtest: re-run failed tests in subprocesses'
updated_at = <Date 2019-07-29.23:45:04.178>
user = 'https://github.com/vstinner'

bugs.python.org fields:

activity = <Date 2019-07-29.23:45:04.178>
actor = 'vstinner'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Tests']
creation = <Date 2019-07-29.23:44:36.211>
creator = 'vstinner'
dependencies = []
files = []
hgrepos = []
issue_num = 37711
keywords = []
message_count = 1.0
messages = ['348700']
nosy_count = 1.0
nosy_names = ['vstinner']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue37711'
versions = ['Python 3.9']
@vstinner
Copy link
Member Author

When using python3 -m test -w, failed tests are re-run in the regrtest main process, even if -jN option is used. If a test does crash, regrtest doesn't remove its temporary directory which can lead to random test failures like bpo-37359.

At least when using -jN, I suggest to run tests in a subprocess to ensure that regrtest is able to cleanup its temporary directory, even if a test does crash.

@vstinner vstinner added 3.9 only security fixes tests Tests in the Lib/test dir labels Jul 29, 2019
@vstinner vstinner changed the title regrtest: re-run tests in subprocesses regrtest: re-run failed tests in subprocesses Jul 29, 2019
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
@vstinner
Copy link
Member Author

vstinner commented Nov 3, 2022

While it would be nice, I don't have the bandwidth to work on this issue, so I just close it.

@vstinner vstinner closed this as completed Nov 3, 2022
@vstinner
Copy link
Member Author

vstinner commented Sep 5, 2023

The feature was implemented in issue #108834.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.9 only security fixes tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vstinner