Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memory leak in ssl certification #81883

Closed
neonene mannequin opened this issue Jul 29, 2019 · 7 comments
Closed

memory leak in ssl certification #81883

neonene mannequin opened this issue Jul 29, 2019 · 7 comments
Assignees
@tiran
Labels
3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes OS-windows performance Performance or resource usage topic-SSL

Comments

@neonene
Copy link
Mannequin

neonene mannequin commented Jul 29, 2019

BPO 37702
Nosy @pfmoore, @tiran, @tjguk, @zware, @zooba, @miss-islington, @neonene
PRs
  • bpo-37702: Fix SSL certificate-store-handles leak #14999
  • bpo-37702: Fix SSL's certificate-store leak on Windows #15632
  • [3.7] bpo-37702: Fix SSL's certificate-store leak on Windows (GH-15632) #15770
  • [3.8] bpo-37702: Fix SSL's certificate-store leak on Windows (GH-15632) #15771
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/tiran'
closed_at = <Date 2019-09-09.13:39:06.071>
created_at = <Date 2019-07-29.07:45:29.743>
labels = ['expert-SSL', '3.8', '3.9', 'performance', '3.7', 'OS-windows']
title = 'memory leak in ssl certification'
updated_at = <Date 2019-09-09.13:48:27.063>
user = 'https://github.com/neonene'

    bugs.python.org fields:

    activity = <Date 2019-09-09.13:48:27.063>
actor = 'steve.dower'
assignee = 'christian.heimes'
closed = True
closed_date = <Date 2019-09-09.13:39:06.071>
closer = 'steve.dower'
components = ['Windows', 'SSL']
creation = <Date 2019-07-29.07:45:29.743>
creator = 'neonene'
dependencies = []
files = []
hgrepos = []
issue_num = 37702
keywords = ['patch']
message_count = 7.0
messages = ['348600', '350927', '351441', '351442', '351463', '351464', '351467']
nosy_count = 7.0
nosy_names = ['paul.moore', 'christian.heimes', 'tim.golden', 'zach.ware', 'steve.dower', 'miss-islington', 'neonene']
pr_nums = ['14999', '15632', '15770', '15771']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'resource usage'
url = 'https://bugs.python.org/issue37702'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']
    @neonene
    Copy link
    Mannequin Author

    neonene mannequin commented Jul 29, 2019

    Windows10/7(x86/x64)
    After bpo-35941 (any PR merged)

    In https-access, memory usage increases by about 200KB per urlopen()
    and easily reach to giga bytes.

    I found out leak of certificate-store-handles in _ssl.c and made patch,
    which works fine for my pc.

    I guess some users are in trouble with this leak.
    I'm about to raise PR, so please review. Thanks!

    @neonene neonene mannequin added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes labels Jul 29, 2019
    @neonene neonene mannequin assigned tiran Jul 29, 2019
    @neonene neonene mannequin added OS-windows topic-SSL performance Performance or resource usage labels Jul 29, 2019
    @neonene
    Copy link
    Mannequin Author

    neonene mannequin commented Aug 31, 2019

    I raised another PR(15632), which keeps the changes to a minimum.
    I hope either PR would be in the 3.7.5 / 3.8.0 official.

    @zooba
    Copy link
    Member

    zooba commented Sep 9, 2019

    Thanks for the simpler patch. I'm happier taking that one, given we know the rest of the code already works.

    @zooba
    Copy link
    Member

    zooba commented Sep 9, 2019

    New changeset ed70129 by Steve Dower (neonene) in branch 'master':
    bpo-37702: Fix SSL's certificate-store leak on Windows (GH-15632)
    ed70129

    @zooba
    Copy link
    Member

    zooba commented Sep 9, 2019

    Closing now, as we're just waiting on the backports to clear CI.

    Thanks for your contributions!

    @zooba zooba closed this as completed Sep 9, 2019
    @miss-islington
    Copy link
    Contributor

    New changeset 472f37a by Miss Islington (bot) in branch '3.7':
    bpo-37702: Fix SSL's certificate-store leak on Windows (GH-15632)
    472f37a

    @zooba
    Copy link
    Member

    zooba commented Sep 9, 2019

    New changeset 5d695b6 by Steve Dower in branch '3.8':
    bpo-37702: Fix SSL's certificate-store leak on Windows (GH-15632)
    5d695b6

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @teodoryantcheff teodoryantcheff mentioned this issue Sep 30, 2023
    Open
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @tiran tiran

    Labels
    3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes OS-windows performance Performance or resource usage topic-SSL
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @tiran @zooba @miss-islington