Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2to3 doesn't work when run from a zipfile #81856

Closed
benjaminp opened this issue Jul 24, 2019 · 5 comments
Closed

2to3 doesn't work when run from a zipfile #81856

benjaminp opened this issue Jul 24, 2019 · 5 comments
Assignees
@benjaminp
Labels
3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes topic-2to3

Comments

@benjaminp
Copy link
Contributor

BPO 37675
Nosy @benjaminp, @miss-islington
PRs
  • closes bpo-37675: Use pkgutil.iter_modules to find fixers in a package rather than listdir. #14942
  • [3.7] closes bpo-37675: Use pkgutil.iter_modules to find fixers in a package rather than listdir. (14942) #14943
  • [2.7] closes bpo-37675: Use pkgutil.iter_modules to find fixers in a package rather than listdir. (14942) #14944
  • [3.8] closes bpo-37675: Use pkgutil.iter_modules to find fixers in a package rather than listdir. (14942) #14945
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/benjaminp'
closed_at = <Date 2019-07-24.23:38:53.355>
created_at = <Date 2019-07-24.23:15:12.994>
labels = ['3.8', '3.7', 'expert-2to3', '3.9']
title = "2to3 doesn't work when run from a zipfile"
updated_at = <Date 2019-07-25.00:00:42.805>
user = 'https://github.com/benjaminp'

    bugs.python.org fields:

    activity = <Date 2019-07-25.00:00:42.805>
actor = 'miss-islington'
assignee = 'benjamin.peterson'
closed = True
closed_date = <Date 2019-07-24.23:38:53.355>
closer = 'benjamin.peterson'
components = ['2to3 (2.x to 3.x conversion tool)']
creation = <Date 2019-07-24.23:15:12.994>
creator = 'benjamin.peterson'
dependencies = []
files = []
hgrepos = []
issue_num = 37675
keywords = ['patch']
message_count = 5.0
messages = ['348413', '348416', '348418', '348419', '348420']
nosy_count = 2.0
nosy_names = ['benjamin.peterson', 'miss-islington']
pr_nums = ['14942', '14943', '14944', '14945']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue37675'
versions = ['Python 2.7', 'Python 3.7', 'Python 3.8', 'Python 3.9']
    @benjaminp
    Copy link
    Contributor Author

    get_all_fix_names does listdir() to find fixers. That breaks if the standard library is in a zipfile. It shouldn't be hard to replace this with pkgutil.iter_modules.

    @benjaminp benjaminp added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes labels Jul 24, 2019
    @benjaminp benjaminp self-assigned this Jul 24, 2019
    @benjaminp
    Copy link
    Contributor Author

    New changeset 93e8aa6 by Benjamin Peterson in branch 'master':
    closes bpo-37675: Use pkgutil.iter_modules to find fixers in a package rather than listdir. (14942)
    93e8aa6

    @miss-islington
    Copy link
    Contributor

    New changeset 9194a20 by Miss Islington (bot) in branch '3.7':
    closes bpo-37675: Use pkgutil.iter_modules to find fixers in a package rather than listdir. (14942)
    9194a20

    @miss-islington
    Copy link
    Contributor

    New changeset 53639dd by Miss Islington (bot) in branch '2.7':
    closes bpo-37675: Use pkgutil.iter_modules to find fixers in a package rather than listdir. (14942)
    53639dd

    @miss-islington
    Copy link
    Contributor

    New changeset 69802f6 by Miss Islington (bot) in branch '3.8':
    closes bpo-37675: Use pkgutil.iter_modules to find fixers in a package rather than listdir. (14942)
    69802f6

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @benjaminp benjaminp

    Labels
    3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes topic-2to3
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @benjaminp @miss-islington