Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make install fails #81834

Closed
erlend-aasland opened this issue Jul 22, 2019 · 5 comments
Closed

make install fails #81834

erlend-aasland opened this issue Jul 22, 2019 · 5 comments
Labels
3.9 only security fixes build The build process and cross-build OS-mac type-bug An unexpected behavior, bug, or error

Comments

@erlend-aasland
Copy link
Contributor

BPO 37653
Nosy @ronaldoussoren, @vstinner, @ned-deily, @erlend-aasland
PRs
  • bpo-37653: Fix make install #14911
    		•
    Files
  • fix.patch: Proposed patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-07-23.16:15:24.111>
created_at = <Date 2019-07-22.15:33:56.311>
labels = ['OS-mac', 'type-bug', '3.9', 'build']
title = 'make install fails'
updated_at = <Date 2019-07-29.18:26:00.636>
user = 'https://github.com/erlend-aasland'

    bugs.python.org fields:

    activity = <Date 2019-07-29.18:26:00.636>
actor = 'ronaldoussoren'
assignee = 'none'
closed = True
closed_date = <Date 2019-07-23.16:15:24.111>
closer = 'ned.deily'
components = ['Build', 'macOS']
creation = <Date 2019-07-22.15:33:56.311>
creator = 'erlendaasland'
dependencies = []
files = ['48497']
hgrepos = []
issue_num = 37653
keywords = ['patch']
message_count = 5.0
messages = ['348300', '348338', '348339', '348673', '348676']
nosy_count = 4.0
nosy_names = ['ronaldoussoren', 'vstinner', 'ned.deily', 'erlendaasland']
pr_nums = ['14911']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue37653'
versions = ['Python 3.9']
    @erlend-aasland
    Copy link
    Contributor Author

    Make install is broken in subtarget libinstall. This was introduced with commit e869281.

    Fix in attached patch.

    @erlend-aasland erlend-aasland added 3.9 only security fixes build The build process and cross-build type-bug An unexpected behavior, bug, or error labels Jul 22, 2019
    @SilentGhost SilentGhost mannequin added 3.8 only security fixes and removed 3.8 only security fixes labels Jul 22, 2019
    @ned-deily
    Copy link
    Member

    New changeset 387c3c5 by Ned Deily (Erlend Egeberg Aasland) in branch 'master':
    bpo-37653: Fix libinstall target in Makefile (GH-14911)
    387c3c5

    @ned-deily
    Copy link
    Member

    Thanks for the PR!

    @vstinner
    Copy link
    Member

    Crap. That's why I didn't want to put the comment "inside" the code, but as separated commands. Well, I learnt something today: bash is the standard :-)

    @ronaldoussoren
    Copy link
    Contributor

    A trick w.r.t. comments in command-lines is to use the ":" command, that's a no-op shell command that ignores its arguments (although you do need to take care with shell special characters as it is just a command like any other).

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.9 only security fixes build The build process and cross-build OS-mac type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @vstinner @ronaldoussoren @ned-deily @erlend-aasland