Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Py_CompileString and PyParser_SimpleParseString not exported in python38.dll #81814

Closed
pyscripter mannequin opened this issue Jul 19, 2019 · 9 comments
Closed

Py_CompileString and PyParser_SimpleParseString not exported in python38.dll #81814

pyscripter mannequin opened this issue Jul 19, 2019 · 9 comments
Labels
3.8 only security fixes 3.9 only security fixes OS-windows release-blocker

Comments

@pyscripter
Copy link
Mannequin

pyscripter mannequin commented Jul 19, 2019

BPO 37633
Nosy @brettcannon, @pfmoore, @vstinner, @tjguk, @benjaminp, @ambv, @zware, @zooba, @miss-islington, @epicfaace
PRs
  • closes bpo-37633: Reëxport some function compatibility wrappers for macros in pythonrun.h. #17056
  • [3.8] closes bpo-37633: Reëxport some function compatibility wrappers for macros in pythonrun.h. (GH-17056) #17057
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-11-05.05:34:17.785>
created_at = <Date 2019-07-19.20:36:46.277>
labels = ['3.8', '3.9', 'OS-windows', 'release-blocker']
title = 'Py_CompileString and PyParser_SimpleParseString not exported in python38.dll'
updated_at = <Date 2019-11-05.14:45:24.080>
user = 'https://bugs.python.org/pyscripter'

    bugs.python.org fields:

    activity = <Date 2019-11-05.14:45:24.080>
actor = 'benjamin.peterson'
assignee = 'none'
closed = True
closed_date = <Date 2019-11-05.05:34:17.785>
closer = 'benjamin.peterson'
components = ['Windows']
creation = <Date 2019-07-19.20:36:46.277>
creator = 'pyscripter'
dependencies = []
files = []
hgrepos = []
issue_num = 37633
keywords = ['patch', '3.8regression']
message_count = 9.0
messages = ['348198', '348211', '349206', '354709', '355980', '356000', '356003', '356027', '356036']
nosy_count = 12.0
nosy_names = ['brett.cannon', 'paul.moore', 'vstinner', 'tim.golden', 'pyscripter', 'benjamin.peterson', 'lukasz.langa', 'zach.ware', 'steve.dower', 'miss-islington', 'epicfaace', 'Arnaud Diederen']
pr_nums = ['17056', '17057']
priority = 'release blocker'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue37633'
versions = ['Python 3.8', 'Python 3.9']
    @pyscripter
    Copy link
    Mannequin Author

    pyscripter mannequin commented Jul 19, 2019

    Py_CompileString and PyParser_SimpleParseString and possibly other related functions are not exported in Python 3.8 b2 DLL. This is unintentional, not documented and unnecessarily breaks backward compatibility.

    bpo-37189 was similar and related to PyRun_String. This was fixed in Python 3.8b2. Please provide fixes to the above two functions as well.

    To confirm the error:
>>> import ctypes
>>> api = ctypes.pythonapi
>>> hasattr(api, "PyParser_SimpleParseString")
False
>>> hasattr(api2, "Py_CompileString")
False

    @pyscripter pyscripter mannequin added 3.8 only security fixes OS-windows labels Jul 19, 2019
    @pyscripter
    Copy link
    Mannequin Author

    pyscripter mannequin commented Jul 20, 2019

    Py_CompileStringFlags is not exported either.

    @epicfaace
    Copy link
    Mannequin

    epicfaace mannequin commented Aug 8, 2019

    I can take this up.

    @ArnaudDiederen
    Copy link
    Mannequin

    ArnaudDiederen mannequin commented Oct 15, 2019

    Python 3.8 was released yesterday, but this issue was unfortunately not addressed, making it as an embedded runtime.

    Are there plans to fix this for a minor 3.8 release?

    Thanks!

    @ned-deily ned-deily added the 3.9 only security fixes label Oct 15, 2019
    @brettcannon
    Copy link
    Member

    I've flagged this as a release blocker so the Release Manager can make a call about whether this should hold up future releases.

    @benjaminp
    Copy link
    Contributor

    New changeset 62161ce by Benjamin Peterson in branch 'master':
    closes bpo-37633: Reëxport some function compatibility wrappers for macros in pythonrun.h. (GH-17056)
    62161ce

    @miss-islington
    Copy link
    Contributor

    New changeset 4c22e16 by Miss Islington (bot) in branch '3.8':
    closes bpo-37633: Reëxport some function compatibility wrappers for macros in pythonrun.h. (GH-17056)
    4c22e16

    @vstinner
    Copy link
    Member

    vstinner commented Nov 5, 2019

    closes bpo-37633: Reëxport some function compatibility wrappers for macros in pythonrun.h. (GH-17056)

    Aha, finally more diversity of languages in commit messages! :-D

    @benjaminp
    Copy link
    Contributor

    On Tue, Nov 5, 2019, at 03:12, STINNER Victor wrote:

    STINNER Victor vstinner@python.org added the comment:

    closes bpo-37633: Reëxport some function compatibility wrappers for macros in pythonrun.h. (GH-17056)

    Aha, finally more diversity of languages in commit messages! :-D

    This kind of orthography is allowable if obscure in English. https://en.wikipedia.org/wiki/Diaeresis_(diacritic)#English

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes 3.9 only security fixes OS-windows release-blocker
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    5 participants
    @brettcannon @vstinner @benjaminp @ned-deily @miss-islington