Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vectorcall: keyword names must be strings #81721

Closed
jdemeyer opened this issue Jul 10, 2019 · 2 comments
Closed

vectorcall: keyword names must be strings #81721

jdemeyer opened this issue Jul 10, 2019 · 2 comments
Labels
3.9 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement

Comments

@jdemeyer
Copy link
Contributor

BPO 37540
Nosy @vstinner, @encukou, @markshannon, @jdemeyer, @miss-islington
PRs
  • bpo-37540: vectorcall: keyword names must be strings #14682
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-08-16.12:15:11.754>
created_at = <Date 2019-07-10.08:06:51.626>
labels = ['interpreter-core', 'type-feature', '3.9']
title = 'vectorcall: keyword names must be strings'
updated_at = <Date 2019-08-16.12:15:11.753>
user = 'https://github.com/jdemeyer'

    bugs.python.org fields:

    activity = <Date 2019-08-16.12:15:11.753>
actor = 'jdemeyer'
assignee = 'none'
closed = True
closed_date = <Date 2019-08-16.12:15:11.754>
closer = 'jdemeyer'
components = ['Interpreter Core']
creation = <Date 2019-07-10.08:06:51.626>
creator = 'jdemeyer'
dependencies = []
files = []
hgrepos = []
issue_num = 37540
keywords = ['patch']
message_count = 2.0
messages = ['347608', '349854']
nosy_count = 5.0
nosy_names = ['vstinner', 'petr.viktorin', 'Mark.Shannon', 'jdemeyer', 'miss-islington']
pr_nums = ['14682']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue37540'
versions = ['Python 3.9']
    @jdemeyer
    Copy link
    Contributor Author

    Keyword names in calls are expected to be strings, however it's currently not clear who should enforce/check this.

    I suggest to fix this for vectorcall/METH_FASTCALL and specify that it's the caller's job to make sure that keyword names are strings (str subclasses are allowed).

    @jdemeyer jdemeyer added 3.9 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement labels Jul 10, 2019
    @miss-islington
    Copy link
    Contributor

    New changeset 0567786 by Miss Islington (bot) (Jeroen Demeyer) in branch 'master':
    bpo-37540: vectorcall: keyword names must be strings (GH-14682)
    0567786

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.9 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @jdemeyer @miss-islington