Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some FormatMessageW() calls use FORMAT_MESSAGE_FROM_SYSTEM without FORMAT_MESSAGE_IGNORE_INSERTS #81626

Closed
ZackerySpytz mannequin opened this issue Jun 28, 2019 · 8 comments
Closed

Some FormatMessageW() calls use FORMAT_MESSAGE_FROM_SYSTEM without FORMAT_MESSAGE_IGNORE_INSERTS #81626

ZackerySpytz mannequin opened this issue Jun 28, 2019 · 8 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes extension-modules C modules in the Modules dir OS-windows

Comments

@ZackerySpytz
Copy link
Mannequin

ZackerySpytz mannequin commented Jun 28, 2019

BPO 37445
Nosy @pfmoore, @tjguk, @zware, @zooba, @ZackerySpytz, @miss-islington
PRs
  • bpo-37445: Include FORMAT_MESSAGE_IGNORE_INSERTS in FormatMessageW() calls #14462
  • [3.8] bpo-37445: Include FORMAT_MESSAGE_IGNORE_INSERTS in FormatMessageW() calls (GH-14462) #15742
  • [3.7] bpo-37445: Include FORMAT_MESSAGE_IGNORE_INSERTS in FormatMessageW() calls (GH-14462) #15743
  • [2.7] bpo-37445: Include FORMAT_MESSAGE_IGNORE_INSERTS in FormatMessageW() calls (GH-14462) #15822
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-09-09.10:35:46.233>
created_at = <Date 2019-06-28.23:58:58.584>
labels = ['extension-modules', '3.7', '3.8', '3.9', 'OS-windows']
title = 'Some FormatMessageW() calls use FORMAT_MESSAGE_FROM_SYSTEM without FORMAT_MESSAGE_IGNORE_INSERTS'
updated_at = <Date 2019-09-11.09:39:49.709>
user = 'https://github.com/ZackerySpytz'

    bugs.python.org fields:

    activity = <Date 2019-09-11.09:39:49.709>
actor = 'steve.dower'
assignee = 'none'
closed = True
closed_date = <Date 2019-09-09.10:35:46.233>
closer = 'steve.dower'
components = ['Extension Modules', 'Windows']
creation = <Date 2019-06-28.23:58:58.584>
creator = 'ZackerySpytz'
dependencies = []
files = []
hgrepos = []
issue_num = 37445
keywords = ['patch']
message_count = 8.0
messages = ['346875', '351374', '351389', '351393', '351413', '351760', '351782', '351783']
nosy_count = 6.0
nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'steve.dower', 'ZackerySpytz', 'miss-islington']
pr_nums = ['14462', '15742', '15743', '15822']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue37445'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']
    @ZackerySpytz
    Copy link
    Mannequin Author

    ZackerySpytz mannequin commented Jun 28, 2019

    As mentioned in bpo-26493, some FormatMessageW() calls use the FORMAT_MESSAGE_FROM_SYSTEM flag without FORMAT_MESSAGE_IGNORE_INSERTS. This will cause FormatMessageW() to fail if there are insert sequences in the message definition.

    I will create a PR for this issue.

    @ZackerySpytz ZackerySpytz mannequin added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes extension-modules C modules in the Modules dir OS-windows labels Jun 28, 2019
    @zooba
    Copy link
    Member

    zooba commented Sep 9, 2019

    New changeset a656365 by Steve Dower (Zackery Spytz) in branch 'master':
    bpo-37445: Include FORMAT_MESSAGE_IGNORE_INSERTS in FormatMessageW() calls (GH-14462)
    a656365

    @miss-islington
    Copy link
    Contributor

    New changeset e103732 by Miss Islington (bot) in branch '3.8':
    bpo-37445: Include FORMAT_MESSAGE_IGNORE_INSERTS in FormatMessageW() calls (GH-14462)
    e103732

    @miss-islington
    Copy link
    Contributor

    New changeset 1af2c0e by Miss Islington (bot) in branch '3.7':
    bpo-37445: Include FORMAT_MESSAGE_IGNORE_INSERTS in FormatMessageW() calls (GH-14462)
    1af2c0e

    @zooba
    Copy link
    Member

    zooba commented Sep 9, 2019

    Going to say this doesn't qualify for 2.7 (unless someone insists and provides a PR), given the lack of reports that anything is actually impacted.

    @zooba zooba closed this as completed Sep 9, 2019
    @ZackerySpytz
    Copy link
    Mannequin Author

    ZackerySpytz mannequin commented Sep 11, 2019

    Hi, Steve. I've created a backport for 2.7 (PR 15822). Please take a look.

    @zooba
    Copy link
    Member

    zooba commented Sep 11, 2019

    New changeset 289c5ea by Steve Dower (Zackery Spytz) in branch '2.7':
    bpo-37445: Include FORMAT_MESSAGE_IGNORE_INSERTS in FormatMessageW() calls (GH-15822)
    289c5ea

    @zooba
    Copy link
    Member

    zooba commented Sep 11, 2019

    Thanks, Zackery!

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes extension-modules C modules in the Modules dir OS-windows
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @zooba @miss-islington