update vendorized expat to 2.2.7 #81618

benjaminp · 2019-06-28T03:29:05Z

BPO	37437
Nosy	@benjaminp, @ned-deily, @miss-islington
PRs	closes bpo-37437: Update vendorized expat to 2.2.7. #14436 [3.8] closes bpo-37437: Update vendorized expat to 2.2.7. (GH-14436) #14437 [3.7] closes bpo-37437: Update vendorized expat to 2.2.7. (GH-14436) #14438 [3.6] closes bpo-37437: Update vendorized expat to 2.2.7. (GH-14436) #14439 [2.7] closes bpo-37437: Update vendorized expat to 2.2.7. (GH-14436) #14440 bpo-37437: Pass -Wno-unreachable-code when compiling expat. #14470 [3.7] bpo-37437: Pass -Wno-unreachable-code when compiling expat. (GH-14470) #14471 [3.6] bpo-37437: Pass -Wno-unreachable-code when compiling expat. (GH-14470) #14472 [3.8] bpo-37437: Pass -Wno-unreachable-code when compiling expat. #14473 Put pyexpatns.h include back. bpo-37437 #14539 [3.8] Put pyexpatns.h include back. bpo-37437 (GH-14539) #14540 [3.7] Put pyexpatns.h include back. bpo-37437 (GH-14539) #14541 [3.6] Put pyexpatns.h include back. bpo-37437 (GH-14539) #14542 [2.7] Put pyexpatns.h include back. bpo-37437 (GH-14539) #14543 [2.7] Put pyexpatns.h include back. bpo-37437 (GH-14539) #14544

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2019-06-28.03:54:47.738>
created_at = <Date 2019-06-28.03:29:05.189>
labels = ['expert-XML', '3.7', '3.8', '3.9']
title = 'update vendorized expat to 2.2.7'
updated_at = <Date 2019-07-02.22:34:02.867>
user = 'https://github.com/benjaminp'

bugs.python.org fields:

activity = <Date 2019-07-02.22:34:02.867>
actor = 'ned.deily'
assignee = 'none'
closed = True
closed_date = <Date 2019-06-28.03:54:47.738>
closer = 'benjamin.peterson'
components = ['XML']
creation = <Date 2019-06-28.03:29:05.189>
creator = 'benjamin.peterson'
dependencies = []
files = []
hgrepos = []
issue_num = 37437
keywords = ['patch']
message_count = 17.0
messages = ['346794', '346795', '346796', '346797', '346798', '346799', '346848', '346902', '346904', '346905', '346906', '347103', '347104', '347105', '347106', '347107', '347159']
nosy_count = 3.0
nosy_names = ['benjamin.peterson', 'ned.deily', 'miss-islington']
pr_nums = ['14436', '14437', '14438', '14439', '14440', '14470', '14471', '14472', '14473', '14539', '14540', '14541', '14542', '14543', '14544']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue37437'
versions = ['Python 2.7', 'Python 3.6', 'Python 3.7', 'Python 3.8', 'Python 3.9']

benjaminp · 2019-06-28T03:29:05Z

Fixes CVE-2018-20843.

benjaminp · 2019-06-28T03:54:48Z

New changeset 3b03b09 by Benjamin Peterson in branch 'master':
closes bpo-37437: Update vendorized expat to 2.2.7. (GH-14436)
3b03b09

miss-islington · 2019-06-28T04:12:45Z

New changeset 515a026 by Miss Islington (bot) in branch '3.8':
closes bpo-37437: Update vendorized expat to 2.2.7. (GH-14436)
515a026

miss-islington · 2019-06-28T04:15:12Z

New changeset 87cc668 by Miss Islington (bot) in branch '3.7':
closes bpo-37437: Update vendorized expat to 2.2.7. (GH-14436)
87cc668

miss-islington · 2019-06-28T04:16:51Z

New changeset 6632906 by Miss Islington (bot) in branch '3.6':
closes bpo-37437: Update vendorized expat to 2.2.7. (GH-14436)
6632906

miss-islington · 2019-06-28T04:24:55Z

New changeset 4397c68 by Miss Islington (bot) in branch '2.7':
closes bpo-37437: Update vendorized expat to 2.2.7. (GH-14436)
4397c68

ned-deily · 2019-06-28T18:12:53Z

The expat update introduces unsightly build warnings:

gcc -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -std=c99 -Wextra -Wno-unused-result -Wno-unused-parameter -Wno-missing-field-initializers -Wstrict-prototypes -Werror=implicit-function-declaration -I./Include/internal -DHAVE_EXPAT_CONFIG_H=1 -DXML_POOR_ENTROPY=1 -DUSE_PYEXPAT_CAPI -I/Users/nad/Projects/PyDev/active/dev/3x/source/Modules/expat -I./Include -I. -I/Users/nad/Projects/PyDev/active/dev/3x/source/Include -I/Users/nad/Projects/PyDev/active/dev/3x/source -c /Users/nad/Projects/PyDev/active/dev/3x/source/Modules/expat/xmlparse.c -o build/temp.macosx-10.14-x86_64-3.9/Users/nad/Projects/PyDev/active/dev/3x/source/Modules/expat/xmlparse.o -Wno-implicit-fallthrough
/Users/nad/Projects/PyDev/active/dev/3x/source/Modules/expat/xmlparse.c:3027:11: warning: code will never be executed
[-Wunreachable-code]
parser->m_characterDataHandler(parser->m_handlerArg, parser->m_dataBuf, 0);
^~~~~~
/Users/nad/Projects/PyDev/active/dev/3x/source/Modules/expat/xmlparse.c:3026:18: note: silence by adding parentheses to
mark code as explicitly dead
else if (0 && parser->m_characterDataHandler)
^
/* DISABLES CODE */ ( )
/Users/nad/Projects/PyDev/active/dev/3x/source/Modules/expat/xmlparse.c:3728:9: warning: code will never be executed
[-Wunreachable-code]
parser->m_characterDataHandler(parser->m_handlerArg, parser->m_dataBuf, 0);
^~~~~~
/Users/nad/Projects/PyDev/active/dev/3x/source/Modules/expat/xmlparse.c:3727:16: note: silence by adding parentheses to
mark code as explicitly dead
else if (0 && parser->m_characterDataHandler)
^
/* DISABLES CODE */ ( )
2 warnings generated.

benjaminp · 2019-06-29T23:00:29Z

New changeset 95da310 by Benjamin Peterson in branch 'master':
bpo-37437: Pass -Wno-unreachable-code when compiling expat. (GH-14470)
95da310

miss-islington · 2019-06-29T23:16:49Z

New changeset ffa419a by Miss Islington (bot) in branch '3.7':
bpo-37437: Pass -Wno-unreachable-code when compiling expat. (GH-14470)
ffa419a

benjaminp · 2019-06-29T23:52:04Z

New changeset 66c42f8 by Benjamin Peterson in branch '3.8':
[3.8] bpo-37437: Pass -Wno-unreachable-code when compiling expat. (GH-14473)
66c42f8

ned-deily · 2019-06-30T00:36:34Z

New changeset a1093e4 by Ned Deily (Miss Islington (bot)) in branch '3.6':
bpo-37437: Pass -Wno-unreachable-code when compiling expat. (GH-14470) (GH-14472)
a1093e4

benjaminp · 2019-07-02T05:07:49Z

New changeset 2cd0792 by Benjamin Peterson in branch 'master':
Put pyexpatns.h include back. bpo-37437 (GH-14539)
2cd0792

miss-islington · 2019-07-02T05:26:44Z

New changeset 9bd5479 by Miss Islington (bot) in branch '3.8':
Put pyexpatns.h include back. bpo-37437 (GH-14539)
9bd5479

miss-islington · 2019-07-02T05:29:09Z

New changeset f3130fa by Miss Islington (bot) in branch '3.7':
Put pyexpatns.h include back. bpo-37437 (GH-14539)
f3130fa

miss-islington · 2019-07-02T05:38:36Z

New changeset 03b0128 by Miss Islington (bot) in branch '2.7':
Put pyexpatns.h include back. bpo-37437 (GH-14539)
03b0128

benjaminp · 2019-07-02T05:48:19Z

New changeset 29d6905 by Benjamin Peterson (Miss Islington (bot)) in branch '3.6':
Put pyexpatns.h include back. bpo-37437 (GH-14542)
29d6905

ned-deily · 2019-07-02T22:34:03Z

New changeset cc0bf97 by Ned Deily (Miss Islington (bot)) in branch '3.7':
closes bpo-37437: Update vendorized expat to 2.2.7. (GH-14436)
cc0bf97

New changeset 3e24dd5 by Ned Deily (Miss Islington (bot)) in branch '3.7':
bpo-37437: Pass -Wno-unreachable-code when compiling expat. (GH-14470)
3e24dd5

New changeset 6348364 by Ned Deily (Miss Islington (bot)) in branch '3.7':
Put pyexpatns.h include back. bpo-37437 (GH-14539)
6348364

benjaminp added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes topic-XML labels Jun 28, 2019

benjaminp closed this as completed Jun 28, 2019

ezio-melotti transferred this issue from another repository Apr 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update vendorized expat to 2.2.7 #81618

update vendorized expat to 2.2.7 #81618

benjaminp commented Jun 28, 2019

benjaminp commented Jun 28, 2019

benjaminp commented Jun 28, 2019

miss-islington commented Jun 28, 2019

miss-islington commented Jun 28, 2019

miss-islington commented Jun 28, 2019

miss-islington commented Jun 28, 2019

ned-deily commented Jun 28, 2019

benjaminp commented Jun 29, 2019

miss-islington commented Jun 29, 2019

benjaminp commented Jun 29, 2019

ned-deily commented Jun 30, 2019

benjaminp commented Jul 2, 2019

miss-islington commented Jul 2, 2019

miss-islington commented Jul 2, 2019

miss-islington commented Jul 2, 2019

benjaminp commented Jul 2, 2019

ned-deily commented Jul 2, 2019

update vendorized expat to 2.2.7 #81618

update vendorized expat to 2.2.7 #81618

Comments

benjaminp commented Jun 28, 2019

benjaminp commented Jun 28, 2019

benjaminp commented Jun 28, 2019

miss-islington commented Jun 28, 2019

miss-islington commented Jun 28, 2019

miss-islington commented Jun 28, 2019

miss-islington commented Jun 28, 2019

ned-deily commented Jun 28, 2019

benjaminp commented Jun 29, 2019

miss-islington commented Jun 29, 2019

benjaminp commented Jun 29, 2019

ned-deily commented Jun 30, 2019

benjaminp commented Jul 2, 2019

miss-islington commented Jul 2, 2019

miss-islington commented Jul 2, 2019

miss-islington commented Jul 2, 2019

benjaminp commented Jul 2, 2019

ned-deily commented Jul 2, 2019