Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pure Python implementation of queue #81575

Closed
pablogsal opened this issue Jun 25, 2019 · 3 comments
Closed

Fix pure Python implementation of queue #81575

pablogsal opened this issue Jun 25, 2019 · 3 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes extension-modules C modules in the Modules dir interpreter-core (Objects, Python, Grammar, and Parser dirs) tests Tests in the Lib/test dir

Comments

@pablogsal
Copy link
Member

BPO 37394
Nosy @pablogsal, @miss-islington
PRs
  • bpo-37394: Fix pure Python implementation of queue #14351
  • [3.8] bpo-37394: Fix pure Python implementation of the queue module (GH-14351) #14362
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-06-25.01:53:46.910>
created_at = <Date 2019-06-25.01:07:26.899>
labels = ['interpreter-core', '3.8', '3.9', 'extension-modules', '3.7', 'tests']
title = 'Fix pure Python implementation of queue'
updated_at = <Date 2019-06-25.02:14:41.316>
user = 'https://github.com/pablogsal'

    bugs.python.org fields:

    activity = <Date 2019-06-25.02:14:41.316>
actor = 'miss-islington'
assignee = 'none'
closed = True
closed_date = <Date 2019-06-25.01:53:46.910>
closer = 'pablogsal'
components = ['Extension Modules', 'Interpreter Core', 'Tests']
creation = <Date 2019-06-25.01:07:26.899>
creator = 'pablogsal'
dependencies = []
files = []
hgrepos = []
issue_num = 37394
keywords = ['patch']
message_count = 3.0
messages = ['346466', '346474', '346475']
nosy_count = 2.0
nosy_names = ['pablogsal', 'miss-islington']
pr_nums = ['14351', '14362']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue37394'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']
    @pablogsal
    Copy link
    Member Author

    The test for the queue module are not testing correctly both the C and the Python implementation of the queue. A consequence is that some errors are being overseed (like the fact that an AttributeError is used instead of an ImportError to catch when importing _queue fails).

    @pablogsal pablogsal added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes extension-modules C modules in the Modules dir interpreter-core (Objects, Python, Grammar, and Parser dirs) tests Tests in the Lib/test dir labels Jun 25, 2019
    @pablogsal
    Copy link
    Member Author

    New changeset 3f5b908 by Pablo Galindo in branch 'master':
    bpo-37394: Fix pure Python implementation of the queue module (GH-14351)
    3f5b908

    @miss-islington
    Copy link
    Contributor

    New changeset 5bf3b89 by Miss Islington (bot) in branch '3.8':
    bpo-37394: Fix pure Python implementation of the queue module (GH-14351)
    5bf3b89

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes extension-modules C modules in the Modules dir interpreter-core (Objects, Python, Grammar, and Parser dirs) tests Tests in the Lib/test dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @pablogsal @miss-islington