Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use io.open_code for .pth files #81545

Closed
zooba opened this issue Jun 21, 2019 · 4 comments
Closed

Use io.open_code for .pth files #81545

zooba opened this issue Jun 21, 2019 · 4 comments
Assignees
@zooba
Labels
3.8 only security fixes 3.9 only security fixes type-bug An unexpected behavior, bug, or error

Comments

@zooba
Copy link
Member

zooba commented Jun 21, 2019

BPO 37364
Nosy @tiran, @zooba, @miss-islington
PRs
  • bpo-37364: Use io.open_code() to read .pth files #14299
  • [3.8] bpo-37364: Use io.open_code() to read .pth files (GH-14299) #14300
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
closed_at = <Date 2019-06-21.22:56:35.329>
created_at = <Date 2019-06-21.15:46:04.888>
labels = ['type-bug', '3.8', '3.9']
title = 'Use io.open_code for .pth files'
updated_at = <Date 2019-06-21.22:56:35.328>
user = 'https://github.com/zooba'

    bugs.python.org fields:

    activity = <Date 2019-06-21.22:56:35.328>
actor = 'steve.dower'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2019-06-21.22:56:35.329>
closer = 'steve.dower'
components = []
creation = <Date 2019-06-21.15:46:04.888>
creator = 'steve.dower'
dependencies = []
files = []
hgrepos = []
issue_num = 37364
keywords = ['patch']
message_count = 4.0
messages = ['346230', '346231', '346259', '346263']
nosy_count = 3.0
nosy_names = ['christian.heimes', 'steve.dower', 'miss-islington']
pr_nums = ['14299', '14300']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue37364'
versions = ['Python 3.8', 'Python 3.9']
    @zooba
    Copy link
    Member Author

    zooba commented Jun 21, 2019

    Since .pth files may contain executable code, we should open them using io.open_code().

    @zooba zooba added 3.8 only security fixes 3.9 only security fixes type-bug An unexpected behavior, bug, or error labels Jun 21, 2019
    @tiran
    Copy link
    Member

    tiran commented Jun 21, 2019

    +1

    @zooba zooba self-assigned this Jun 21, 2019
    @miss-islington
    Copy link
    Contributor

    New changeset 184f3d4 by Miss Islington (bot) (Steve Dower) in branch 'master':
    bpo-37364: Use io.open_code() to read .pth files (GH-14299)
    184f3d4

    @miss-islington
    Copy link
    Contributor

    New changeset 35202c7 by Miss Islington (bot) in branch '3.8':
    bpo-37364: Use io.open_code() to read .pth files (GH-14299)
    35202c7

    @zooba zooba closed this as completed Jun 21, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @zooba zooba

    Labels
    3.8 only security fixes 3.9 only security fixes type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @tiran @zooba @miss-islington