Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use vectorcall for functools.partial #81539

Closed
jdemeyer opened this issue Jun 21, 2019 · 2 comments
Closed

Use vectorcall for functools.partial #81539

jdemeyer opened this issue Jun 21, 2019 · 2 comments
Labels
3.9 only security fixes performance Performance or resource usage stdlib Python modules in the Lib dir

Comments

@jdemeyer
Copy link
Contributor

BPO 37358
Nosy @vstinner, @encukou, @markshannon, @jdemeyer, @miss-islington
PRs
  • bpo-37358: Use vectorcall for functools.partial #14284
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-07-13.15:10:03.104>
created_at = <Date 2019-06-21.08:51:53.228>
labels = ['library', '3.9', 'performance']
title = 'Use vectorcall for functools.partial'
updated_at = <Date 2019-07-13.15:10:03.104>
user = 'https://github.com/jdemeyer'

    bugs.python.org fields:

    activity = <Date 2019-07-13.15:10:03.104>
actor = 'petr.viktorin'
assignee = 'none'
closed = True
closed_date = <Date 2019-07-13.15:10:03.104>
closer = 'petr.viktorin'
components = ['Library (Lib)']
creation = <Date 2019-06-21.08:51:53.228>
creator = 'jdemeyer'
dependencies = []
files = []
hgrepos = []
issue_num = 37358
keywords = ['patch']
message_count = 2.0
messages = ['346193', '347831']
nosy_count = 5.0
nosy_names = ['vstinner', 'petr.viktorin', 'Mark.Shannon', 'jdemeyer', 'miss-islington']
pr_nums = ['14284']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'performance'
url = 'https://bugs.python.org/issue37358'
versions = ['Python 3.9']
    @jdemeyer
    Copy link
    Contributor Author

    functools.partial already has some optimizations to use vectorcall (formerly known as fastcall) for its onward calls, so it makes a lot of sense to also use vectorcall when being called.

    @jdemeyer jdemeyer added 3.9 only security fixes stdlib Python modules in the Lib dir performance Performance or resource usage labels Jun 21, 2019
    @miss-islington
    Copy link
    Contributor

    New changeset ed184c0 by Miss Islington (bot) (Jeroen Demeyer) in branch 'master':
    bpo-37358: Use vectorcall for functools.partial (GH-14284)
    ed184c0

    @encukou encukou closed this as completed Jul 13, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.9 only security fixes performance Performance or resource usage stdlib Python modules in the Lib dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @encukou @jdemeyer @miss-islington