Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDLE: fix Query subclass tab focus traversal order #81506

Closed
terryjreedy opened this issue Jun 18, 2019 · 4 comments
Closed

IDLE: fix Query subclass tab focus traversal order #81506

terryjreedy opened this issue Jun 18, 2019 · 4 comments
Assignees
@terryjreedy
Labels
3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes topic-IDLE type-bug An unexpected behavior, bug, or error

Comments

@terryjreedy
Copy link
Member

BPO 37325
Nosy @terryjreedy, @miss-islington
PRs
  • bpo-37325: Fix focus traversal for 2 IDLE dialogs #14209
  • [3.7] bpo-37325: Fix focus traversal for 2 IDLE dialogs (GH-14209) #14210
  • [3.8] bpo-37325: Fix focus traversal for 2 IDLE dialogs (GH-14209) #14211
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2019-06-18.22:40:25.444>
created_at = <Date 2019-06-18.02:07:11.964>
labels = ['3.8', 'expert-IDLE', 'type-bug', '3.7', '3.9']
title = 'IDLE: fix Query subclass tab focus traversal order'
updated_at = <Date 2019-06-18.22:40:25.443>
user = 'https://github.com/terryjreedy'

    bugs.python.org fields:

    activity = <Date 2019-06-18.22:40:25.443>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2019-06-18.22:40:25.444>
closer = 'terry.reedy'
components = ['IDLE']
creation = <Date 2019-06-18.02:07:11.964>
creator = 'terry.reedy'
dependencies = []
files = []
hgrepos = []
issue_num = 37325
keywords = ['patch']
message_count = 4.0
messages = ['345940', '346009', '346011', '346012']
nosy_count = 2.0
nosy_names = ['terry.reedy', 'miss-islington']
pr_nums = ['14209', '14210', '14211']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue37325'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']
    @terryjreedy
    Copy link
    Member Author

    query.Query creates a popup with entry and ok/cancel buttons, in that order. Tabbing moves from the entry in that order. Currently, subclasses that add widgets add them after the 3 above, so they follow Cancel in the tab order. They do this by overriding create_widgets and initially calling super.create_widgets.

    Added widgets should follow the entry box and precede the exit buttons. To do this, they should be created in between. Proposed solution: create_widgets calls 'extra_widgets' (pass for Query) after creating the Entry. Subclasses override to add widgets.

    @terryjreedy terryjreedy added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes labels Jun 18, 2019
    @terryjreedy terryjreedy self-assigned this Jun 18, 2019
    @terryjreedy terryjreedy added topic-IDLE type-bug An unexpected behavior, bug, or error labels Jun 18, 2019
    @terryjreedy
    Copy link
    Member Author

    New changeset 54cf2e0 by Terry Jan Reedy in branch 'master':
    bpo-37325: Fix focus traversal for 2 IDLE dialogs (bpo-14209)
    54cf2e0

    @miss-islington
    Copy link
    Contributor

    New changeset 44d46e3 by Miss Islington (bot) in branch '3.7':
    bpo-37325: Fix focus traversal for 2 IDLE dialogs (GH-14209)
    44d46e3

    @miss-islington
    Copy link
    Contributor

    New changeset b626b11 by Miss Islington (bot) in branch '3.8':
    bpo-37325: Fix focus traversal for 2 IDLE dialogs (GH-14209)
    b626b11

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @terryjreedy terryjreedy

    Labels
    3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes topic-IDLE type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @terryjreedy @miss-islington