Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mmap.mmap() passes the wrong variable to PySys_Audit() #81497

Closed
ZackerySpytz mannequin opened this issue Jun 17, 2019 · 4 comments
Closed

mmap.mmap() passes the wrong variable to PySys_Audit() #81497

ZackerySpytz mannequin opened this issue Jun 17, 2019 · 4 comments
Labels
3.8 only security fixes 3.9 only security fixes extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error

Comments

@ZackerySpytz
Copy link
Mannequin

ZackerySpytz mannequin commented Jun 17, 2019

BPO 37316
Nosy @zooba, @ZackerySpytz
PRs
  • bpo-37316: mmap.mmap() passes the wrong variable to PySys_Audit() #14152
  • [3.8] bpo-37316: mmap.mmap() passes the wrong variable to PySys_Audit() (GH-14152) #14289
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-06-21.16:48:58.185>
created_at = <Date 2019-06-17.09:51:19.875>
labels = ['extension-modules', 'type-bug', '3.8', '3.9']
title = 'mmap.mmap() passes the wrong variable to PySys_Audit()'
updated_at = <Date 2019-06-21.16:48:58.184>
user = 'https://github.com/ZackerySpytz'

    bugs.python.org fields:

    activity = <Date 2019-06-21.16:48:58.184>
actor = 'steve.dower'
assignee = 'none'
closed = True
closed_date = <Date 2019-06-21.16:48:58.185>
closer = 'steve.dower'
components = ['Extension Modules']
creation = <Date 2019-06-17.09:51:19.875>
creator = 'ZackerySpytz'
dependencies = []
files = []
hgrepos = []
issue_num = 37316
keywords = ['patch']
message_count = 4.0
messages = ['345834', '346227', '346228', '346234']
nosy_count = 2.0
nosy_names = ['steve.dower', 'ZackerySpytz']
pr_nums = ['14152', '14289']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue37316'
versions = ['Python 3.8', 'Python 3.9']
    @ZackerySpytz
    Copy link
    Mannequin Author

    ZackerySpytz mannequin commented Jun 17, 2019

    new_mmap_object() should pass the fd variable to PySys_Audit(), not fileno.

    Also, there's a missing call to va_end() in PySys_Audit() itself.

    @ZackerySpytz ZackerySpytz mannequin added 3.8 only security fixes 3.9 only security fixes extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error labels Jun 17, 2019
    @zooba
    Copy link
    Member

    zooba commented Jun 21, 2019

    Thanks! Well spotted.

    @zooba
    Copy link
    Member

    zooba commented Jun 21, 2019

    New changeset 08286d5 by Steve Dower (Zackery Spytz) in branch 'master':
    bpo-37316: mmap.mmap() passes the wrong variable to PySys_Audit() (GH-14152)
    08286d5

    @zooba
    Copy link
    Member

    zooba commented Jun 21, 2019

    New changeset 6c79477 by Steve Dower in branch '3.8':
    bpo-37316: mmap.mmap() passes the wrong variable to PySys_Audit() (GH-14152)
    6c79477

    @zooba zooba closed this as completed Jun 21, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes 3.9 only security fixes extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @zooba