Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MIME type for Web App Manifest #81486

Closed
filips123 mannequin opened this issue Jun 16, 2019 · 4 comments
Closed

Add MIME type for Web App Manifest #81486

filips123 mannequin opened this issue Jun 16, 2019 · 4 comments
Labels
3.8 only security fixes 3.9 only security fixes type-feature A feature request or enhancement

Comments

@filips123
Copy link
Mannequin

filips123 mannequin commented Jun 16, 2019

BPO 37305
Nosy @jaraco, @filips123
PRs
  • bpo-37305: add MIME type for Web App Manifest #14199
  • [3.8] bpo-37305: add MIME type for Web App Manifest (GH-14199) #15946
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2019-09-11.14:22:25.546>
    created_at = <Date 2019-06-16.10:41:01.858>
    labels = ['type-feature', '3.8', '3.9']
    title = 'Add MIME type for Web App Manifest'
    updated_at = <Date 2019-09-11.14:22:25.545>
    user = 'https://github.com/filips123'

    bugs.python.org fields:

    activity = <Date 2019-09-11.14:22:25.545>
    actor = 'jaraco'
    assignee = 'none'
    closed = True
    closed_date = <Date 2019-09-11.14:22:25.546>
    closer = 'jaraco'
    components = []
    creation = <Date 2019-06-16.10:41:01.858>
    creator = 'filips123'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 37305
    keywords = ['patch']
    message_count = 4.0
    messages = ['345741', '351867', '351893', '351899']
    nosy_count = 2.0
    nosy_names = ['jaraco', 'filips123']
    pr_nums = ['14199', '15946']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue37305'
    versions = ['Python 3.8', 'Python 3.9']

    @filips123
    Copy link
    Mannequin Author

    filips123 mannequin commented Jun 16, 2019

    Web App Manifest ( https://w3c.github.io/manifest/ ) is "JSON-based manifest file that provides developers with a centralized place to put metadata associated with a web application".

    Although it is not required, it is recommended by W3C ( https://w3c.github.io/manifest/#media-type-registration ) that manifest uses application/manifest+json media type and .webmanifest extension.

    This should also be used by Python's mimetypes module.

    I can submit PR for this, but I don't know if it should be added to types_map or common_types. It is currently not registered with IANA, but it is "for community review and will be submitted to the IESG for review, approval, and registration with IANA".

    If it is not strictly needed for MIME type that it is registered with IANA, I will add it to types_map. If it is, I will add it common_types and later move it to types_map when it will be registered. What should I choose?

    @filips123 filips123 mannequin added the type-feature A feature request or enhancement label Jun 16, 2019
    @jaraco jaraco added 3.8 only security fixes 3.9 only security fixes labels Sep 11, 2019
    @jaraco
    Copy link
    Member

    jaraco commented Sep 11, 2019

    New changeset 4b41745 by Jason R. Coombs (Filip Š) in branch 'master':
    bpo-37305: add MIME type for Web App Manifest (bpo-14199)
    4b41745

    @jaraco
    Copy link
    Member

    jaraco commented Sep 11, 2019

    New changeset 35d0934 by Jason R. Coombs (Miss Islington (bot)) in branch '3.8':
    bpo-37305: add MIME type for Web App Manifest (GH-14199) (bpo-15946)
    35d0934

    @jaraco
    Copy link
    Member

    jaraco commented Sep 11, 2019

    Thanks for the contrib.

    @jaraco jaraco closed this as completed Sep 11, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.8 only security fixes 3.9 only security fixes type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant