Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a Py_XINCREF in classobject.c are not necessary #81481

Closed
shihai1991 opened this issue Jun 16, 2019 · 2 comments
Closed

a Py_XINCREF in classobject.c are not necessary #81481

shihai1991 opened this issue Jun 16, 2019 · 2 comments
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement

Comments

@shihai1991
Copy link
Member

BPO 37300
Nosy @benjaminp, @shihai1991
PRs
  • bpo-37300: a Py_XINCREF in classobject.c are not necessary #14120
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-06-16.20:19:33.523>
created_at = <Date 2019-06-16.02:30:33.222>
labels = ['interpreter-core', 'type-feature']
title = 'a Py_XINCREF in classobject.c are not necessary'
updated_at = <Date 2019-06-16.20:19:33.517>
user = 'https://github.com/shihai1991'

    bugs.python.org fields:

    activity = <Date 2019-06-16.20:19:33.517>
actor = 'benjamin.peterson'
assignee = 'none'
closed = True
closed_date = <Date 2019-06-16.20:19:33.523>
closer = 'benjamin.peterson'
components = ['Interpreter Core']
creation = <Date 2019-06-16.02:30:33.222>
creator = 'shihai1991'
dependencies = []
files = []
hgrepos = []
issue_num = 37300
keywords = ['patch']
message_count = 2.0
messages = ['345737', '345775']
nosy_count = 2.0
nosy_names = ['benjamin.peterson', 'shihai1991']
pr_nums = ['14120']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue37300'
versions = []
    @shihai1991 shihai1991 added interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement labels Jun 16, 2019
    @shihai1991
    Copy link
    Member Author

    a Py_XINCREF in classobject.c are not necessary

    @benjaminp
    Copy link
    Contributor

    New changeset c83356c by Benjamin Peterson (Hai Shi) in branch 'master':
    closes bpo-37300: Remove unnecessary Py_XINCREF in classobject.c. (GH-14120)
    c83356c

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @benjaminp @shihai1991