Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate the parser module #81449

Closed
vstinner opened this issue Jun 13, 2019 · 8 comments
Closed

Deprecate the parser module #81449

vstinner opened this issue Jun 13, 2019 · 8 comments
Labels
3.8 only security fixes stdlib Python modules in the Lib dir

Comments

@vstinner
Copy link
Member

BPO 37268
Nosy @vstinner, @pablogsal, @miss-islington
PRs
  • bpo-37268: Add deprecation notice and a DeprecationWarning for the parser module #15017
  • bpo-37268: test_parser fails when run with -Werror #15183
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-07-30.12:49:09.010>
created_at = <Date 2019-06-13.12:11:39.721>
labels = ['3.8', 'library']
title = 'Deprecate the parser module'
updated_at = <Date 2019-08-08.21:48:04.757>
user = 'https://github.com/vstinner'

    bugs.python.org fields:

    activity = <Date 2019-08-08.21:48:04.757>
actor = 'miss-islington'
assignee = 'none'
closed = True
closed_date = <Date 2019-07-30.12:49:09.010>
closer = 'pablogsal'
components = ['Library (Lib)']
creation = <Date 2019-06-13.12:11:39.721>
creator = 'vstinner'
dependencies = []
files = []
hgrepos = []
issue_num = 37268
keywords = ['patch']
message_count = 8.0
messages = ['345504', '345506', '345507', '345522', '348704', '348706', '348735', '349260']
nosy_count = 3.0
nosy_names = ['vstinner', 'pablogsal', 'miss-islington']
pr_nums = ['15017', '15183']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue37268'
versions = ['Python 3.8']
    @vstinner
    Copy link
    Member Author

    The parser module should be deprecated as soon as possible according to Pablo Galindo Salgo and Guido van Rossum:

    I propose to deprecate it in Python 3.8: add a note in the documentation and emit a DeprecationWarning on "import parser".

    @vstinner vstinner added 3.8 only security fixes stdlib Python modules in the Lib dir labels Jun 13, 2019
    @vstinner
    Copy link
    Member Author

    I searched for "import parser" in GitHub code search, but I failed to find any project using the Python stdlib parser module. I only found copies of the CPython code source which has on "import parser" in Lib/test/test_parser.py.

    @vstinner
    Copy link
    Member Author

    Pablo: Are you interested to implement this change?

    @pablogsal
    Copy link
    Member

    Yep, will make a PR soon.

    @vstinner
    Copy link
    Member Author

    Yep, will make a PR soon.

    Any update on deprecating the parser module?

    @pablogsal
    Copy link
    Member

    Any update on deprecating the parser module?

    Wish granted: PR 15017

    @miss-islington
    Copy link
    Contributor

    New changeset 9211e2f by Miss Islington (bot) (Pablo Galindo) in branch 'master':
    bpo-37268: Add deprecation notice and a DeprecationWarning for the parser module (GH-15017)
    9211e2f

    @miss-islington
    Copy link
    Contributor

    New changeset 10a0a09 by Miss Islington (bot) (Zackery Spytz) in branch 'master':
    bpo-37268: test_parser fails when run with -Werror (GH-15183)
    10a0a09

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes stdlib Python modules in the Lib dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @vstinner @pablogsal @miss-islington